Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21157] - [4.0] [A11y] lists scope and grid

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Jul 2018

Continuing the work done (and merged) in #21087 See the description there for the reasons etc

Summary of Changes

scope=row to title cells
scope=row to column headers

When a cell has a scope it is a th
When a cell is an action eg a checkbox to selectall then it is a td even if it is in a header row

Any styling changes are beyond the scope of this PR

avatar brianteeman brianteeman - open - 17 Jul 2018
avatar brianteeman brianteeman - change - 17 Jul 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2018
Category ⇒ Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_fields com_finder com_installer com_languages com_menus com_messages com_modules
avatar brianteeman brianteeman - change - 17 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2018
Category Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_fields com_finder com_installer com_languages com_menus com_messages com_modules ⇒ Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_fields com_finder com_installer com_languages
avatar brianteeman
brianteeman - comment - 18 Jul 2018

Thanks @Quy all done

avatar Quy
Quy - comment - 19 Jul 2018

Under System > Information > System Information, apply scope there?

avatar brianteeman
brianteeman - comment - 19 Jul 2018

@Quy yes but I will do that in a separate PR

avatar Quy
Quy - comment - 19 Jul 2018

Do the same for Versions > Content History.

avatar Quy Quy - test_item - 19 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 19 Jul 2018

I have tested this item ✅ successfully on aec13ac

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21157.

avatar Quy
Quy - comment - 20 Jul 2018

Do the same under Permissions tab.

avatar zwiastunsw zwiastunsw - test_item - 20 Jul 2018 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 20 Jul 2018

I have tested this item ✅ successfully on aec13ac

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21157.

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jul 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2018

Ready to Commit after two successful tests.

avatar wojsmol
wojsmol - comment - 20 Jul 2018

@franz-wohlkoenig Please r5emove RTC label - PR has merge conflicts.;

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jul 2018
Status Ready to Commit ⇒ Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2018

Back on pending.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21157.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2018

I set RTC having conflicting Files that its not lost and Maintainer decide if merge or not.

avatar brianteeman
brianteeman - comment - 20 Jul 2018

conflicts resolved

avatar Quy Quy - change - 20 Jul 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 20 Jul 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21157.

avatar wilsonge wilsonge - change - 21 Jul 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-07-21 23:30:02
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Jul 2018
avatar wilsonge wilsonge - merge - 21 Jul 2018
avatar wilsonge
wilsonge - comment - 21 Jul 2018

thanks!

avatar brianteeman
brianteeman - comment - 21 Jul 2018

Thanks

Add a Comment

Login with GitHub to post a comment