[#21156] - Media manager doesn't obey relative pathes for video files
- Fixed in Code Base
- 21 Jul 2018
- Medium
- Build: staging
- # 21156
- Diff
- wojsmol:patch-10
User tests: Successful: Unsuccessful:
Pull Request for Issue #21145 .
Summary of Changes
Testing Instructions
- Make sure video files can be uploaded (legal extensions, MIME times). Let's the media folder is www.mysite/mymedia
- Create any sub-folder in main Media folder (for example 'myvideos')
- Upload a video to this new folder, so the correct location is www.mysite/mymedia/myvideo/myvideo.mp4.
- Hover the mouse, notice that the lacking sub-folder part (www.mysite/mymedia/myvideo.mp4)
- Try to click the preview link, get the error about file not existing or not supported format.
- Apply patch and repeat above steps
Expected result
The link to the video file should be resolved to the correct location like for images ( www.mysite/ymedia/myvideo/myvideo.mp4 )
Actual result
The link is broken (lacks the sub-folder part) ( www.mysite/mymedia/myvideo.mp4 )
Documentation Changes Required
no
@tonypartridge @Codereamp please test.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Title |
|
||||||
Sorry, the code fragments were converted to mixed html/plain text mess
I think that tge correct fix is
- <a class="video-preview" href="<?php echo COM_MEDIA_BASEURL, '/', rawurlencode($video->name); ?>" title="escape($video->name); ?>">
- <a class="video-preview" href="<?php echo COM_MEDIA_BASEURL, '/', rawurlencode($video->path_relative); ?>" title="escape($video->name); ?>">
not the proposed
- <?php echo JHtml::_('string.truncate', $this->escape($video->name), 10, false); ?>
- <?php echo JHtml::_('string.truncate', $this->escape($video->path_relative), 10, false); ?>
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21156.
| Labels |
Added:
?
|
||
@Codereamp fixed in latest commit.
I have tested this item
Sorry, I'm new to the reporting/testing so my comment might be irrelevant. Joomla Patch tester lists [Applied Commit SHA: 1051bc2], but here it is listed as SHA: 1051bc2. I see the prefix is the same, but still a little misleading to have different numbers.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21156.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21156.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21156.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-21 01:02:46 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I suspect that the proposed fix (looked at the diff) changes the wrong entity, the title, not url as the primary issue revealed. So to fix the wrong links we should apply
not the proposed
CMIIW
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21156.