[#21129] - [4.0] Core spinning logo
- Closed
- 31 Jul 2018
- Medium
- Build: 4.0-dev
- # 21129
- Diff
- dgrammatiko:ce/4.0-dev-spinner-2
User tests: Successful: Unsuccessful:
A redo of #19677 .
Summary of Changes
Just a web component that creates a spinning logo.
Testing Instructions
Apply this patch.
Make sure Custom Fields are enabled.
Try to edit an article and change the category
Boom...
Enjoy the infinite loop...
Expected result
Actual result
Documentation Changes Required
The only breaking change here is that the core.js Fuction Joomla.loadingLayer() will not load the webcomponent, that needs to be done in the relative layout with:
HTMLHelper::_('webcomponent', 'system/webcomponents/joomla-core-loader.min.js', ['relative' => true, 'version' => 'auto']);This PR depends on #21117
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories JavaScript Repository |
| Labels |
Added:
?
|
||
@brianteeman This PR depends on #21117
The usual way is to keep the pr clean and then to ask testers to make sure they have a dependent pr applied first. This is beneficial for you if there are errors/changes in the other pr. It also means testers can be sure what they are testing and report errors in the correct place. Thanks
Well, in this case, is not so straightforward, because to test this PR you had to apply the other PR. Do npm install, apply this PR and the do node build.js --compilecejs. Nobody will ever go this far to test a PR...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21129.
Way too much going on here in files (some stuff I know is fixed elsewhere) and all the conflicts. Closing this and we can reopen it with a fresh PR when you are ready :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-31 15:34:21 |
| Closed_By | ⇒ | wilsonge |
There appear to be a lot of unrelated changes in this pr