? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
11 Jul 2018

Pull Request for Issue #21076 .

Summary of Changes

A variable didnt exist (due to bad copy pasting)

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 11 Jul 2018
avatar dgrammatiko dgrammatiko - change - 11 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Category JavaScript
avatar dgrammatiko dgrammatiko - change - 11 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Category JavaScript Unit Tests JavaScript
avatar dgrammatiko dgrammatiko - change - 11 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Category JavaScript Unit Tests JavaScript
avatar dgrammatiko dgrammatiko - change - 11 Jul 2018
Labels Removed: ?
avatar brianteeman brianteeman - test_item - 11 Jul 2018 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 11 Jul 2018

I have tested this item ? unsuccessfully on 11cfca9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21077.

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

@brianteeman what was the package you tried to install?
Also which browser did you use?

avatar brianteeman brianteeman - test_item - 11 Jul 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Jul 2018

I have tested this item successfully on 11cfca9

retested after making even more sure the cache was cleared and it worked


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21077.

avatar laoneo
laoneo - comment - 12 Jul 2018

Can you not exclude the js files by wildcard?

avatar dgrammatiko
dgrammatiko - comment - 12 Jul 2018

It conflicts with the first rule

avatar laoneo
laoneo - comment - 12 Jul 2018

Just to have a rough idea, what needs to be done that the .js files do pass too? I'm a bit hesitant to merge this in the state as it is now.

avatar dgrammatiko
dgrammatiko - comment - 12 Jul 2018

what needs to be done that the .js files do pass too?

Nope, the transpiled files (eg dest) should not be part of the linting because these are ES5 files and the linter expect only ES6 files. I'm still in favour of a dedicated source folder and the whole media folder gets created from our tools (eg npm install)

avatar brianteeman
brianteeman - comment - 9 Aug 2018

@dgrammatiko can you resolve the conflicts please

avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2018
Category JavaScript JavaScript Repository
5b7d111 9 Aug 2018 avatar dgrammatiko woof
avatar wilsonge wilsonge - close - 29 Aug 2018
avatar wilsonge wilsonge - merge - 29 Aug 2018
avatar wilsonge wilsonge - change - 29 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-29 10:31:48
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment