[#21077] - [4.0] Console error on installer.js
- Fixed in Code Base
- 29 Aug 2018
- Medium
- Build: 4.0-dev
- # 21077
- Diff
- dgrammatiko:patches/4.0-dev-p1
User tests: Successful: Unsuccessful:
Pull Request for Issue #21076 .
Summary of Changes
A variable didnt exist (due to bad copy pasting)
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
| Category | JavaScript | ⇒ | Unit Tests JavaScript |
| Labels |
Added:
?
|
||
| Category | JavaScript Unit Tests | ⇒ | JavaScript |
| Labels |
Removed:
?
|
||
@brianteeman what was the package you tried to install?
Also which browser did you use?
I have tested this item
retested after making even more sure the cache was cleared and it worked
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21077.
Can you not exclude the js files by wildcard?
It conflicts with the first rule
Just to have a rough idea, what needs to be done that the .js files do pass too? I'm a bit hesitant to merge this in the state as it is now.
what needs to be done that the .js files do pass too?
Nope, the transpiled files (eg dest) should not be part of the linting because these are ES5 files and the linter expect only ES6 files. I'm still in favour of a dedicated source folder and the whole media folder gets created from our tools (eg npm install)
@dgrammatiko can you resolve the conflicts please
| Category | JavaScript | ⇒ | JavaScript Repository |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-29 10:31:48 |
| Closed_By | ⇒ | wilsonge |
I have tested this item? unsuccessfully on 11cfca9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21077.