?
avatar brianteeman
brianteeman
11 Jul 2018

Steps to reproduce the issue

go to the permissions page of an article and then the permissions tab and view source

Actual result

<joomla-tab orientation="vertical" data-ajaxuri="' . $ajaxUri . '" id="permissions-sliders">

Expected result

The $ajaxUri is replaced with something

avatar brianteeman brianteeman - open - 11 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2018
Category Templates (admin)
avatar ggppdk
ggppdk - comment - 11 Jul 2018

Permissions modifications seem to be working properly

Attributes
data-ajaxuri="' . $ajaxUri . '" id="permissions-sliders"
do not seem to be needed here:

bb52edf#diff-fcdfc03068f0957f766ac041cc0eedbcR81

The tag attributes are only needed here ? @dgrammatiko
bb52edf#diff-fcdfc03068f0957f766ac041cc0eedbcR80

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

@brianteeman what @ggppdk is pointing out, tabs dont have an ajax url, that belongs to the custom element permissions. I guess a sync miss

avatar brianteeman
brianteeman - comment - 11 Jul 2018

I am just reporting the error that needs to be fixed

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

actually there are more things that needs to be patched with tabs (the accordion implementation is not a11y although it passed the audit :( )

avatar brianteeman
brianteeman - comment - 11 Jul 2018

roflmao two elements tested for a11y and both failed

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

it's not funny, it means that we need to spend more time and redo them

avatar dgrammatiko
dgrammatiko - comment - 11 Jul 2018

Check #21078

avatar Quy Quy - change - 11 Jul 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-07-11 18:48:38
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 11 Jul 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Jul 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/21074

Add a Comment

Login with GitHub to post a comment