?
avatar brianteeman
brianteeman
11 Jul 2018

Steps to reproduce the issue

Install joomla and then install the sample data

Expected result

Menus are created with unique alias that are lowercase and do NOT include spaces eg author-menu

Actual result

Menus are created without any changes eg Author Menu

This results in menu links in the administrator that are invalid markup because they have a space in the href

Additional comments

Tested in J4 but probably the same problem in J3

avatar brianteeman brianteeman - open - 11 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2018
Category com_installer
avatar Bakual
Bakual - comment - 11 Jul 2018

You mean the "Menu Type"? I don't see an alias for the menu itself. In J3 they seem to work fine, or I miss where it breaks.

avatar brianteeman
brianteeman - comment - 11 Jul 2018

see the video for explanation

sample

avatar Bakual
Bakual - comment - 11 Jul 2018

Works for me in Chrome and Edge both in J3 and J4.
May that be related to the browser how the link is handled?

The line that would need to be changed is

$type = HTMLHelper::_('string.truncate', $menu['title'], 23, true, false);

Adding ApplicationHelper::stringURLSafe($type); to the mix probably solves the issue.

avatar brianteeman
brianteeman - comment - 11 Jul 2018

There are two issues.

  1. A link with a space in it is invalid html. It might work as a link but assistive technology may not understand it.

  2. As shown in the video the value changes when you save

avatar Bakual
Bakual - comment - 11 Jul 2018

Check #21080. That did fix it for me. I did it for J3 since the same issue is present there as well.

I'm closing this issue since we have a PR.

avatar Bakual Bakual - change - 11 Jul 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-07-11 19:02:47
Closed_By Bakual
avatar Bakual Bakual - close - 11 Jul 2018

Add a Comment

Login with GitHub to post a comment