[#21038] - [4.0] Adding language column to com_finder index backend
- Fixed in Code Base
- 14 Jun 2019
- Medium
- Build: 4.0-dev
- # 21038
- Diff
- Hackwar:j4finder_backendlist
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
The list of indexed items in the backend of com_finder does not have a column for the language. Since we have this everywhere else, I'm adding it here, too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
Updated the colspan to 8. I think it would be a waste of CPU cycles to check here again if multilanguage or not. Since it doesn't matter if we have 7, 8, 9 or 42 here, as long as we want it to span the whole table, I wouldn't change this.
Issue when filtering at the same time content map and language
I guess changes are needed in ContentmapField.php
I think that we should not present at all in filters or elsewhere anything related to Content Languages when the languagefilter is disabled, as we now do everywhere in Joomla.
Taxonomy has no idea what a branch means and we could only introduce a special handling for a branch that is named "Language", which again could not be present at all or deactivated or something. I'm not a fan of that...
I have tested this item
I've tested this item with multilingual sample data and made a code inspection.From this point of view the PR works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038.
| Labels |
Removed:
J4 Issue
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038.
| Labels |
Added:
?
|
||
Can we finally merge this?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-14 18:56:04 |
| Closed_By | ⇒ | roland-d |
Thank you.
Thank you!
https://github.com/joomla/joomla-cms/pull/21038/files#diff-96ae0370a620b2bdb4168d9f9ebab161R67
<td colspan="7">Update column to be
7or8depending onMultilanguage::isEnabled()