? ?

Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
29 Jun 2018

This implements the OpenSearch specification into com_finder. OpenSearch allows you to add a sites search to the search engines of your browser for example. Funnily, this code was partially in com_finder already, but has been disabled. This PR makes that working again.

How to test

  • Open your test website with Firefox and go to a page that has either the mod_finder module displayed or the Smart Search search form.
  • In your address bar, there is a menu (the 3 dots). See that there is no "Add Search menu" option (or something similar. It is translated to german in my FF, so I don't know what the original english description is.) or that there is just an entry for com_search. (Click on that and Firefox should shortly after throw an error message.)
  • Apply this PR
  • Now see that a new entry has shown up, named "Search {Site Title}". Click on that and shortly after see a small success notification.
  • Go to your search settings in Firefox and set to display an extra search box and to use suggestions.
  • In the search box, type in a fraction of a word, like "joom" for Joomla. See suggestions being displayed. Select a suggestion and click on search.
  • See that you are being directed to your sites search page.

Note: OpenSearch doesn't work in 3.x for com_search right now either...

avatar Hackwar Hackwar - open - 29 Jun 2018
avatar Hackwar Hackwar - change - 29 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2018
Category Administration com_finder Front End Language & Strings Libraries Modules
avatar Hackwar Hackwar - change - 1 Jul 2018
Labels Added: ? ?
avatar Hackwar
Hackwar - comment - 2 Jul 2018

I hope I was able to fix everything you asked for.

avatar Hackwar
Hackwar - comment - 3 Jul 2018

I fixed the language strings and added the showon.

avatar brianteeman
brianteeman - comment - 3 Jul 2018

It is enough to say "Enable OpenSearch"

avatar Hackwar
Hackwar - comment - 4 Jul 2018

Did the changes. Ready for testing. 😉

avatar carlitorweb
carlitorweb - comment - 6 Jul 2018

Where find the option on firefox:

screenshot_20180706095842

Without the PR, show an error (expected behavior):

screenshot_20180706100019

After applied the PR, all work as expect behavior (highlight here, you need put the Default search engine for your site, for can work well)

screenshot_20180706100656

avatar carlitorweb
carlitorweb - comment - 7 Jul 2018

I have tested this item successfully on b21f878


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20936.

avatar carlitorweb carlitorweb - test_item - 7 Jul 2018 - Tested successfully
avatar wilsonge wilsonge - change - 7 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-07 18:06:21
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 Jul 2018
avatar wilsonge wilsonge - merge - 7 Jul 2018

Add a Comment

Login with GitHub to post a comment