Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#20894] - [plg_user_profile] Add RTL check to ToS field

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
27 Jun 2018

Pull Request for Issue # .

Summary of Changes

This adds RTL check to ToS field for popover positioning. Missed it in #20412.

Testing Instructions

Install and enable an RTL language. Enable the plugin and ToS field. Go to registration page and check that ToS field popover is positioned the same way as other popovers.

Expected result

Popover positioned correctly.

Actual result

Popover not positioned correctly.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 27 Jun 2018
avatar SharkyKZ SharkyKZ - change - 27 Jun 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2018
Category ⇒ Front End Plugins
avatar infograf768
infograf768 - comment - 27 Jun 2018

OK on review.

avatar Quy Quy - test_item - 27 Jun 2018 - Tested successfully
avatar Quy
Quy - comment - 27 Jun 2018

I have tested this item ✅ successfully on b22e63b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Jul 2018

@infograf768 can you please mark your Test as successfully on Issue Tracker?

avatar infograf768
infograf768 - comment - 3 Jul 2018

@SharkyKZ
while you are there, could you correct the alignment of the Agree/No radio buttons?
These small changes would work for both LTR and RTL:

		$css = '#jform_profile_tos {width: 18em; margin: 0 !important; padding: 0 2px !important;}
				#jform_profile_tos input {margin: 4px 5px 0 0 !important; width: 10px !important;}
				#jform_profile_tos label {margin: 0 20px 0 0 !important; width: auto;}
				';

After adding this patch I get here:
LTR
screen shot 2018-07-03 at 16 11 49

RTL (faked with French)
screen shot 2018-07-03 at 16 12 18

Before (RTL as it is much worse there):
screen shot 2018-07-03 at 16 13 43

avatar SharkyKZ
SharkyKZ - comment - 3 Jul 2018

@infograf768 thanks for the tip. Removing CSS completely. No sense to have it here.

avatar SharkyKZ SharkyKZ - change - 3 Jul 2018
Labels Added: ?
avatar infograf768
infograf768 - comment - 3 Jul 2018

Removing CSS completely. No sense to have it here.

Right, did not even test that before proposing the possible solution. ?

avatar infograf768 infograf768 - test_item - 3 Jul 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 3 Jul 2018

I have tested this item ✅ successfully on 20eeef5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894.

avatar Quy Quy - test_item - 3 Jul 2018 - Tested successfully
avatar Quy
Quy - comment - 3 Jul 2018

I have tested this item ✅ successfully on 20eeef5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894.

avatar Quy Quy - change - 3 Jul 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 3 Jul 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20894.

avatar mbabker mbabker - change - 7 Jul 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-07-07 16:31:22
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 7 Jul 2018
avatar mbabker mbabker - merge - 7 Jul 2018

Add a Comment

Login with GitHub to post a comment