[#20893] - Update default plugin configs
- Closed
- 8 Aug 2021
- Medium
- Build: staging
- # 20893
- Diff
- SharkyKZ:sqlPluginParams_1
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
As per #20563, this syncs default plugin param values in installation SQL files with changes made in PRs #20544, #20456, #20422, #20412 and #20410. This mainly affects numeric values that were stored as strings.
Testing Instructions
Code review.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql MS SQL |
| Labels |
Added:
?
|
||
| Category | SQL Installation Postgresql MS SQL | ⇒ | SQL Installation Postgresql MS SQL Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20893.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20893.
Conflicts solved.
Do we have tests for all 3 database engines?
I removed RTC.
We need tests for mysql, pgsql and mssql please. Include the version in the testing comment.
Thanks for your effort testing this.
| Labels |
Removed:
?
|
||
3rd database test pending....
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-08 20:08:55 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Removed: ? |
||
Dear @SharkyKZ
in preperation of the upcomming release of Joomla 3.10 we have used GitHubs rename feature to rename the staging branch into 3.10-dev. Usually GitHub moves all existing PRs towards the new branch just fine, but here it didnt work. The reason seems to be that the fork of the CMS that was used as base for this PR has been deleted so GitHub does no longer have a base to rebase the PR against the new branch and we are also not able to reopen the PR. For that reason GitHub closed this PR in my name, when this issue is still valid It would require a new PR against the new 3.10-dev or 4.0-dev branch.
I have tested this item✅ successfully on db777e4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20893.