[#20855] - [3.9] Add Argon2id Password Support
- Fixed in Code Base
- 28 Aug 2018
- Medium
- Build: 3.9-dev
- # 20855
- Diff
- zero-24:argon2id
User tests: Successful: Unsuccessful:
Pull Request for Issue #20826
Summary of Changes
Per https://wiki.php.net/rfc/argon2_password_hash_enhancements Argon2id password hashes will be supported in PHP 7.3. We should add support for this alongside our existing Argon2i logic.
Testing Instructions
review
Expected result
Argon2id PW supported
Actual result
Argon2id PW NOT supported
Documentation Changes Required
@mbabker can you tell me where you documented the Argon2i support?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
fixed by the last commit thanks @HLeithner
can you tell me where you documented the Argon2i support?
It's not really documented anywhere. We don't have a place covering this part of the API AFAIK.
J4i the rfc has been accepted and is already implemented in php 7.3.
I have tested this item
Successfully on PHP 7.3.0alpha4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20855.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-28 23:34:36 |
| Closed_By | ⇒ | mbabker |
I think this will not work.
You have to check for "$argon2id" before checking for "$argon2i" in the if Statement because strpos "$argon2i" will already be true for "$argon2id"