[#20854] - [4.0] Various improvements to the Local FileSystem plugin
- Fixed in Code Base
- 26 Jun 2018
- Medium
- Build: 4.0-dev
- # 20854
- Diff
- infograf768:4-0_local_filesystem
User tests: Successful: Unsuccessful:
Pull Request for Issue #20851
Summary of Changes
- Modify plugin description to inform of its usage
- Modify Media Manager Alert when no filesystem plugin is enabled by adding a link to the plugins manager
- Correct the hard coded "Local" name given to the plugin by allowing use of default lang string.
- Alpha order lang strings and cs for the spaces before and after the
=sign.
Testing Instructions
Before patch
Edit the plugin, enable it, test name display in Media manager.
Disable plugin, test display in Media Manager.
After patch: test custom name and default language name setting
Check description.
Disable plugin and see Alert in Media Manager.
Result after patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media Language & Strings Front End Plugins |
| Labels |
Added:
?
?
|
||
@wilsonge @brianteeman
In this PR, I just respected the wish of the original coder by letting a user enter a value in a simple text field. I guessed that whoever merged that did also wanted this...
As it was not multilingual aware, I did, as we do elsewhere in code (Offline) keep the possibility of a custom Name but added a lang string to use per default.
It is indeed much more simple to just return the default lang string.
Will modify now.
Concerning the Warning in the description of the plugin, I STRONGLY disagree to take it off. We also use that type of warning for authentication and it is really useful to users.
We use the warning in the authentication plugin because if you disable them then you break your site and you cannot access it. That is not the case here. You have already added, correctly, a notice in the component if there is no plugin enabled. It is just the same as com_redirect and com_finder.
What is your problem? Adding the warning is not such a big issue that it would need a formal decision from the UK Academy for Information Systems to keep in or not.
Also, it is common to not use com_finder or com_redirect but much less common to not use com_media. In this specific case it is also a major change vs all former Joomla releases.
I think it is better to put a warning. You do not think so. That's fine. You do not have to agree with me.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20854.
Thank you for listening and making the requested changes
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20854.
Deleting comments that you do not agree with is an abuse of your github privileges - please stop doing that and stop making the personal attacks
I also deleted the phrase that you considered as attacks. Full stop.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20854.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-26 14:45:57 |
| Closed_By | ⇒ | laoneo |
Sorry but I dont understand why you would want to have a configurable display name or an option to change it in the plugin.
Yes it should be a language string and just like all other language string if you want to change it then you would create a language override.
Something like "Use Language Default Name" is meaningless as I have no idea here what it is.