? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
16 Jun 2018

Pull Request for Issue #20756

Summary of Changes

Fix Disabled state when nothing is checked in a list

Testing Instructions

Please look #20756 for detail

avatar Fedik Fedik - open - 16 Jun 2018
avatar Fedik Fedik - change - 16 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2018
Category JavaScript Repository
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jun 2018
Title
Toolbar button CE: Fix Disabled state when nothing is checked in a list. Fix #20756
[4.0] Toolbar button CE: Fix Disabled state when nothing is checked in a list. Fix #20756
avatar joomla-cms-bot joomla-cms-bot - edited - 16 Jun 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jun 2018

Changed Title to show its about [4.0].

avatar brianteeman brianteeman - test_item - 16 Jun 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Jun 2018

I have tested this item successfully on 6b6072b

Reported issue is fixed

Not sure if it is related or not but the batch button is always enabled


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20777.

avatar carlitorweb
carlitorweb - comment - 16 Jun 2018

Without this PR, toolbar for me works normally. Or maybe I not understand this, in the way, I should do. Or maybe this was fixed in other PR.

video_2018-06-16_110458

avatar Quy
Quy - comment - 16 Jun 2018

See video in #20756

Buttons in toolbar should not be enabled when no entries are selected.

avatar carlitorweb
carlitorweb - comment - 16 Jun 2018

@Quy I did. I follow what Brian did on the issue report, but still work normally without the PR

new

avatar Quy
Quy - comment - 16 Jun 2018

Click on the Check All Items checkbox.
Buttons enabled.
Click on the Check All Items checkbox again.
Buttons should be disabled, but they are not.

avatar carlitorweb
carlitorweb - comment - 16 Jun 2018

Oh!, I understand all wrong :( sorry and thank you for patience @Quy

avatar carlitorweb carlitorweb - test_item - 16 Jun 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 16 Jun 2018

I have tested this item successfully on 6b6072b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20777.

avatar carlitorweb
carlitorweb - comment - 16 Jun 2018

So sorry for no understand well at first, sometimes my English make me look like an idiot :(

avatar Quy
Quy - comment - 16 Jun 2018

No worries. Thanks so much for testing. ?

avatar Quy Quy - change - 16 Jun 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Jun 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20777.

avatar Quy
Quy - comment - 16 Jun 2018

Not sure if it is related or not but the batch button is always enabled

Batch button should behave the same as the other buttons.

avatar laoneo laoneo - change - 16 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-16 16:07:10
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 16 Jun 2018
avatar laoneo laoneo - merge - 16 Jun 2018
avatar Fedik
Fedik - comment - 17 Jun 2018

@brianteeman the batch button is another type of Toolbar Button (PopupButton),
currently changes (make a Custom Element) affect only Toolbar StandardButton

Batch button should behave the same as the other buttons.

I agree, but not today :)

avatar brianteeman
brianteeman - comment - 17 Jun 2018

OK lets merge this one then and batch can be a new pr

Add a Comment

Login with GitHub to post a comment