[#20746] - Better mode autoloading.
- Fixed in Code Base
- 18 Jun 2018
- Medium
- Build: staging
- # 20746
- Diff
- okonomiyaki3000:CodeMirror-BetterModeAutoloading
User tests: Successful: Unsuccessful:
Summary of Changes
Improvement to editor mode autoselection.
Should now find the correct mode whether the option is set to a mode's name, mime-type, or extension.
Setting the mode is also improved, especially for php mode.
Testing Instructions
Use codemirror. Open as many document types as possible.
Especially try testing PHP documents before and after applying the patch.
Expected result
Mode should be selected correctly so that syntax highlighting and other mode-specific features should work normally.
Actual result
Before this change there is a problem with PHP documents. If they contain HTML sections, it will not be highlighted properly and features such as tag autoclosing will not work.
After this change, all is well.
Documentation Changes Required
Nope.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
can this PR be tested as Appveyor failes?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20746.
@franz-wohlkoenig Yes, you can ignore the Appveyor failure. It only failed because it timed out. Whatever reason it timed out surely has nothing to do with this PR.
@okonomiyaki3000 can you give please an Example of " PHP documents contain HTML sections" to test?
For example: templates/protostar/index.php
I have tested this item
Without PR:
With PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20746.
Yep, that's what I'm talking about.
@okonomiyaki3000 i showed Screenshots cause Tester maybe don't know how it should look.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20746.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-18 02:48:59 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Appveyor failed because it took too long. It is not a problem with this change.