? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
14 Jun 2018

Summary of Changes

When running the build script, we put packages in two directories with semi-consistent names (but variable enough to make scripting mildly annoying, just look at the diff for this PR). IMO there's really no need for this, just shove them all in one package. For whomever is running releases they just need to read file names if they're doing anything special, for end users they never see this process anyway, and for the nightly build scripts as I move them (back) onto the Jenkins box it simplifies things just enough to slow my gray hair growth by about two hours.

Testing Instructions

Apply patch, run build script, check output (compiled packages) is in one directory.

avatar mbabker mbabker - open - 14 Jun 2018
avatar mbabker mbabker - change - 14 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2018
Category Repository
avatar brianteeman
brianteeman - comment - 14 Jun 2018

Tested with Ubuntu for Windows (or whatever they are calling it.

Packages built correctly before patch in sub-directories
Packages built correctly after patch in one directory

Both cases I got this error but I suspect thats me and not the script. Just posting it for completeness

rm: cannot remove '/mnt/c/htdocs/cms/build/tmp': Permission denied
PHP Warning:  mkdir(): File exists in /mnt/c/htdocs/cms/build/build.php on line 92
avatar brianteeman brianteeman - test_item - 14 Jun 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Jun 2018

I have tested this item successfully on b726550


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20745.

avatar laoneo laoneo - test_item - 15 Jun 2018 - Tested successfully
avatar laoneo
laoneo - comment - 15 Jun 2018

I have tested this item successfully on b726550


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20745.

avatar laoneo laoneo - change - 15 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-15 05:59:26
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 15 Jun 2018
avatar laoneo laoneo - merge - 15 Jun 2018

Add a Comment

Login with GitHub to post a comment