Thanks for feedback.

This shouldn't be displayed on a single language site. If he only reason to do that is to let people know that joomla can be multilingual then we are really doing something very very wrong in telling people the features of joomla

Who the hell is going to know what are the intentions of a user installing Joomla for the first time? You? Mono or multilanguage? In 3.x was the same as here: user had the choice.
Your comment does not make sense and I think —as others around— that you are inded toxic. Period.

Unless we've removed the ability to install additional languages from the installer, by the time you reach the admin panel you should already be aware you can set up Joomla in a way to run its frontend in multiple languages. So I agree, this plugin doesn't need to show up in the dashboard module unless you've already set up multiple content languages or language packs or whatever the extra step is to make this actually be meaningful. Progressive disclosure, you know, that thing we've been begging to do for years with the toolbar ?

by the time you reach the admin panel you should already be aware you can set up Joomla in a way to run its frontend in multiple languages.

Wrong. People may just want to install their language for a monolingual site use because English is NOT their lang of choice.

You people have decided to take off the possibility to set a test multiingual site at install time in a clear way. Take your responsibilities.

I’m sure I speak for more than myself here, but the way you voice your
displeasure with changes being made in 4.0 far too often comes across as
demeaning and borderline on the attack. It’s one thing to disagree, ask
Allon how often I disagree with him; it’s another thing to insult or attack.

On Mon, Jun 11, 2018 at 8:17 AM infograf768 notifications@github.com
wrote:

by the time you reach the admin panel you should already be aware you can
set up Joomla in a way to run its frontend in multiple languages.

Wrong. People may just want to install their language for a monolingual
site use because English is NOT their lang of choice.

You people have decided to take off the possibility to set a test
multiingual site at install time in a clear way. Take your responsibilities.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#20711 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfodAIdZsUQg78aK7fvWFEh8SlOiNcks5t7m3OgaJpZM4UiH6n
.

--

• Michael Please pardon any errors, this message was sent from my iPhone.

Let's forget about joomla 4 and revert everything back to joomla 1.0

Can we keep focus on the topic please. I agree here too, as long as there are no additional languages installed, it makes no sense to be able to see the installation link for multilingual. This should be possible in the plugin to detect.

This should be possible in the plugin to detect.

Yes it's quite simple to do. One could add checks to the onSampledataGetOverview() method in the plugin and return empty if it should not show.

I can see arguments for having it both ways (I actually asked JM about this detail during his development):

• Having it always show means people see the possibility for such a sample installation is there. Once criteriums are met it even works. We currently only have one sampledata plugin installed, having it this way also makes clear that module is supposed to be a list, not a single "blog sampledata installation" module. It's also not like that list gets messy with two entries vs only the blog one.
• Having it hidden is more like progressive disclosure. Michael is right in that and I can follow that argument as well (it was my inital thought after all). It's a bit different to the toolbar thought since in the toolbar you would see the buttons pop up as soon as you select something, whereas here you would not immediately see the result of adding a second content language. So it would look more like "magic" behaviour.

Personally I don't have strong feelings in any direction. But lets not shoot down this PR or make people angry just because of that tiny detail. Lets get it tested and merged since it is a needed and helpful feature. It would be easy enough to change after it is merged anyway.

When you install the other sample data plugin - Sample Blog - you have a working site with meaningful and helpful content
The same is not true for the sample data from this plugin. It is good for testing but it doesnt showcase anything

The intention isn't to showcase anything beside having a working multilingual setup with associated sample menuitems, categories and articles.
Which imho is a perfectly fine use of sample data.

So maybe it should be called something other than sample then. Perhaps Example Setup

Anyway I just find it odd that the two plugins do not serve the same usecase

So maybe it should be called something other than sample then. Perhaps Example Setup

I don't mind how it is called. The module and plugins were written as a replacement for the sample data SQL files, but it can actually do whatever you want. Imho it also makes sense to be used for the multilingual setup.
To be fair, it's sort of a sample data as well, just a bit more sophisticated if you want. Using the term "sample data" a bit more broad.

but the way you voice your displeasure with changes being made in 4.0 far too often comes across as demeaning and borderline on the attack.

Yes, it is not even borderline, it is clear that I am quite pissed to see that some very useful features we took time (sometimes years) to get into Joomla are just thrown away in the dust bin without further discussion. And it is always the same people defending that policy who are also fighting against ways to make our CMS "great again" under the pretext that what is presented to them would be back to middle ages or whatever (read above).

Just reintroduce what we had when installing Joomla in 3.x which was chosing the admin and site default language and a basic multilang site and I would not have to propose such a PR as this one.
Taking that off WAS going back to joomla 1.0!!!

Evidently the easiest way for this plugin is simply to NOT enable it when installing a clean joomla site as we do when updating. This or waiting for a second language to be installed to be able to display it is totally useless in my opinion as new users would not even know there is this possibility or would already have created some data which would make this setting useless or broken.

In this case, better just close this PR.

1. No functionality is being removed. It is progressive disclosure just like other parts of Joomla.
2. Installing multilingual sample data is not that old. IIRC it was not introduced until Javier was on gsoc
3. No user who installed joomla using a webhost installer ever saw the options to install sample data before.
4. Displaying every possible feature on the home page or they won't know it's possible is nonsensical Do we have the extension installer on the home page? Of course not because it lives in its own place. It doesn't need to be in the home page for people to know that you can install extensions.
5. Having the option to install a configuration profile (it's not sample data) is great but if the first thing a user gets when the select it is an error message that's a bad first experience of Joomla.

I am closing this. No use to explain the reason further.
Happy?

No not happy. It was a simple request to have this useful feature only
present when it is usable

On 12 June 2018 at 08:18, infograf768 notifications@github.com wrote:

Closed #20711 #20711.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
#20711 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RxwGLNbZW3fNQbTvqtV0E655ynNks5t72s0gaJpZM4UiH6n
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Since apparently JM isn't willing to adjust the code to Brians request, can we please reopen this PR and leave it as it, get it tested and merged. As I said before it's easy enough to do a follow up PR which changes that behaviour. It can then be discussed in that followup PR without this PR here being shut down due to childish behavior (and I think more than one acts childish here).

Reopened as requested

I have tested this item ✅ successfully on 41e95f2

The plugin works as expected and sets up a multilingual site with a sample articles, categories and menuitem for each installed language. All properly associated to eachother. Tested with three languages (english, french, german) after doscivering and enabling the plugin

I detected some issues which are unrelated to this PR:

• Switching language doesn't directly switch to the associated article, instead goes back to the homepage.
• Category edit form doesn't show association tab.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20711.}

Switching language doesn't directly switch to the associated article, instead goes back to the homepage.
Category edit form doesn't show association tab.

Some aspects are taken care of in a PR by @laoneo , remaining issues may be related tomodern routing in 4.0.
See: #20692

Ok, going to merge this one. Would be good if somebody can come up with a follow up pr which shows the sample data only when more than one language is installed. Thanks @infograf768 for patience and @brianteeman to raise awareness that it should be enable only when multiple languages are enabled.

Would be good if somebody can come up with a follow up pr which shows the sample data only when more than one language is installed.

That would make this plugin a bug squad testers only stuff.

I'll do that PR tomorrow as requested (not because I'm in favor). Please discuss it then in that PR.