? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
11 Jun 2018

Summary of Changes

Since introduced in 2010, the FormHelper class has always had a note about how the pluralization logic for form entity types should use a proper inflector, but it never being a big deal because our core API "only" supports entity types that are pluralized by tacking the letter S onto a word (field and rule). We have had an inflector in our API since 2011. It's 2018, I think we can use the inflector now.

Testing Instructions

There should be no practical change here really. Form fields and rules registered through path lookups should keep working. If you actually have a custom Form API entity type, and its pluralization doesn't follow the simple "add S to word" (lets just say entity for the sake of discussion since right now the code would make that "entitys" for the path name when it should be "entities" following correct language rules), the incorrect spelling is deprecated and should raise a log notice (though to be honest the odds of this code path ever being triggered are going to be slim to none).

avatar mbabker mbabker - open - 11 Jun 2018
avatar mbabker mbabker - change - 11 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jun 2018
Category Libraries
avatar wilsonge wilsonge - close - 19 Jun 2018
avatar wilsonge wilsonge - merge - 19 Jun 2018
avatar wilsonge wilsonge - change - 19 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-19 18:37:01
Closed_By wilsonge
Labels Added: ?

Add a Comment

Login with GitHub to post a comment