J4 Issue ?
avatar mbabker
mbabker
9 Jun 2018

With the current test architecture, there is no gained value in running unit tests on AppVeyor (Windows environment) on 4.0. Kill off the integration for that branch.

avatar mbabker mbabker - open - 9 Jun 2018
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Jun 2018
avatar brianteeman
brianteeman - comment - 9 Jun 2018

while it is regularly failing and the failures ignored I dont see any value in having it right now

avatar rdeutz
rdeutz - comment - 9 Jun 2018

it runs very well after the sprint we had in colonge this year, not sure what happend but will have a lock

avatar mbabker
mbabker - comment - 9 Jun 2018

It’s not that it doesn’t run well for what it’s configured to do on 4.0,
but there is almost nothing being tested in AppVeyor that’s worth spinning
up a Windows environment to run. The integration and system tests should
run in a Windows environment, and maybe that can be done on Drone with
Docker. The stuff that it really matters for testing on Windows (SQL
Server, filesystem, WinCache integrations) is mostly covered in the
Framework repos now and the stuff that’s still in the CMS’ cases are all in
Drone in their own environments.

For 3.x, it’s worth spending the time looking at the issues since the full
test suite is still run here and not in split repos/groups. For 4.0, just
blacklist it.

On Sat, Jun 9, 2018 at 11:20 AM Robert Deutz notifications@github.com
wrote:

it runs very well after the sprint we had in colonge this year, not sure
what happend but will have a lock


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20707 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfob1HPjN7REigSPdtVZJHQSL4YTvOks5t6_XcgaJpZM4UhYfL
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar rdeutz
rdeutz - comment - 9 Jun 2018

There are unit test running, yes we need to do more but I can list here 100 areas we need to do more. It doesn't hurt to let it run and it is easier to build on top of a working env as to create a new one.

I have seen two test failing (for stanging) because of time limits, my guess is that this is because of the crypt lib and the polyfill we have included this thing takes a long time under 5.6.

avatar mbabker
mbabker - comment - 9 Jun 2018

If we get it going then even better. Just a little annoying when I’m
working in the Framework repos and have to wait a while because we don’t
have concurrent builds across projects on our account (so there have been
times I’ve had to wait for 3 or 4 CMS builds to run before I get my build,
and in the current 4.0 state this isn’t producing anything of value; if
we’re running integration or system tests on AppVeyor then great and I’ll
shut up and wait my turn for my job to run).

On Sat, Jun 9, 2018 at 1:10 PM Robert Deutz notifications@github.com
wrote:

There are unit test running, yes we need to do more but I can list here
100 areas we need to do more. It doesn't hurt to let it run and it is
easier to build on top of a working env as to create a new one.

I have seen two test failing (for stanging) because of time limits, my
guess is that this is because of the crypt lib and the polyfill we have
included this thing takes a long time under 5.6.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20707 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoSokmAar5joZJuh2HVwzs7bj-rZJks5t7A-MgaJpZM4UhYfL
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Jun 2018
Category Unit Tests
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Jun 2018
Status New Discussion
avatar brianteeman brianteeman - change - 10 Jun 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 10 Jun 2018
avatar brianteeman
brianteeman - comment - 11 Jun 2018

Dont know if it is relevant but PR #20708 failed with
Build execution time has reached the maximum allowed time for your plan (60 minutes).

avatar mbabker
mbabker - comment - 11 Jun 2018

It's a constant trend with 3.x and PHP 5.6 it seems. One of the first tests just stalls.

avatar brianteeman
brianteeman - comment - 23 Jul 2018

@rdeutz any update?

avatar brianteeman
brianteeman - comment - 9 Aug 2018

@puneet0191 any update on what should be happening here please

avatar rdeutz
rdeutz - comment - 11 Aug 2018

@brianteeman we are woking on getting more ressources but this involves OSM. I requested some money but this request got lost somewhere in the process, so we need to shift money. Will take some time.

avatar rdeutz rdeutz - change - 11 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-11 09:44:37
Closed_By rdeutz
avatar rdeutz rdeutz - close - 11 Aug 2018

Add a Comment

Login with GitHub to post a comment