? Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
9 Jun 2018

Summary of Changes

When creating a new custom field of the type repeatable and the fieldname is left empty, the values are not stored. This changed makes the fieldname required thus making sure the values can be stored.

Testing Instructions

  1. Setup a Joomla 3.9 installation
  2. Go to Content Fields
  3. Create a new field by clicking New
  4. Enter the Title Repeatable
  5. Select the type repeatable
  6. Add a new Form Field by clicking on the green +
  7. Leave the Name empty
  8. Set the Type to Text
  9. The form now looks like this:
    image
  10. Save & Close the field
  11. Click on Articles
  12. Click on New
  13. Enter the article title
  14. Click on the Fields tab
  15. There is the repeatable field we just created
  16. Click on the green + to add a value
  17. Enter a value
  18. Click on the green + again
  19. Enter a second value
  20. Save the article
  21. Notice the two rows are there but there are no values
  22. Apply the patch
  23. Go to Content -> Fields
  24. Edit the Repeatable field we created in step 10
  25. Notice that the Name field is now required
  26. Enter a name
  27. Save & Close the field
  28. Repeat step 11 until 19
  29. Notice the two rows are there with values this time.

Expected result

Values are stored and shown

Actual result

Values are not stored and not shown

Documentation Changes Required

None

avatar roland-d roland-d - open - 9 Jun 2018
avatar roland-d roland-d - change - 9 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2018
Category Front End Plugins
avatar roland-d roland-d - change - 9 Jun 2018
The description was changed
avatar roland-d roland-d - edited - 9 Jun 2018
avatar carlitorweb carlitorweb - test_item - 9 Jun 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 9 Jun 2018

I have tested this item successfully on e78544c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20706.

avatar laoneo laoneo - test_item - 9 Jun 2018 - Tested successfully
avatar laoneo
laoneo - comment - 9 Jun 2018

I have tested this item successfully on e78544c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20706.

avatar laoneo
laoneo - comment - 9 Jun 2018

I have tested this item successfully on e78544c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20706.

avatar Quy Quy - change - 9 Jun 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jun 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20706.

avatar Quy
Quy - comment - 9 Jun 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20706.

avatar mbabker mbabker - change - 12 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-12 22:42:28
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 12 Jun 2018
avatar mbabker mbabker - merge - 12 Jun 2018

Add a Comment

Login with GitHub to post a comment