?
avatar joomlahenk
joomlahenk
9 Jun 2018

Steps to reproduce the issue

Open page using protostar template.
In browser inspect elements

Expected result

p {
margin: 0 0 0.75em;
}

Actual result

p {
margin: 0 0 0.75;
}

System information (as much as possible)

J! 3.8.8
Using less compiler plugin with lessc version 0.3.9

Additional comments

Discovered that the problem is in ..\media\jui\less\type.less
p {
margin: 0 0 @baselineheight / 2;
}
But since @baselineheight is a factor and has no dimension, then margin also gets no dimension.
So change to:
p {
margin: 0 0 @baselineheight / 2em;
}
This solved the problem.
I gave element p just as an example, but there are many more (like h1,h2,... blockquote, etc).

avatar joomlahenk joomlahenk - open - 9 Jun 2018
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Jun 2018
avatar SharkyKZ
SharkyKZ - comment - 9 Jun 2018

Can't reproduce this. @baselineheight in Protostar is 18px:
https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/less/variables.less#L56
Resulting value is 9px:

p {
    margin: 0 0 9px;
}
avatar joomlahenk
joomlahenk - comment - 9 Jun 2018

Yes if set with px as a dimension, but @baselineheight is also used for css line-height property, which has no dimension. So for that I should set @baselineheight without dimension.

avatar SharkyKZ
SharkyKZ - comment - 9 Jun 2018

line-height can be defined in length units. In any case, this is coming from Bootstrap http://getbootstrap.com/2.3.2/base-css.html#body-copy.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Jun 2018

@SharkyKZ close as no Core-Issue?

avatar joomlahenk
joomlahenk - comment - 9 Jun 2018

OK, can be closed.

avatar joomlahenk joomlahenk - change - 9 Jun 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-06-09 10:41:28
Closed_By joomlahenk
avatar joomlahenk joomlahenk - close - 9 Jun 2018

Add a Comment

Login with GitHub to post a comment