User tests: Successful: Unsuccessful:
Pull Request for Issue # ?.
This pull request (PR) removes the bootstrap class flex-column
from the menu module's ul
element and changes class navbar-nav
to nav
in the Cassiopeia template's (s)css so it fits to the html.
The flex-column
class makes it impossible to get horizontal menus in the header area of Casiopeia, see picture in section "Actual result" below, and so the apperance is not as shown on the template's preview picture.
After removing the flex-column` class, the menu still does not look like it should, see following picture:
The reason is that in (s)css for the header area the navbar-nav
class is used instead of nav
.
After changing that, the menu looks like on the template's preview, see picture in section "Expected result" below.
Please don't test yet, I have to check how to provide compiled and minified template.css.
Use current 4.0-dev branch with the default Cassiopeia frontent template and have a menu in module position menu
which should be shown in horizontal direction, and some other menus in some side position shown in vertical direction.
I used blog testing data and moved the "Main Menu Blog" module to the menu
position. In the module's advanced setting there is no class suffix defined for the module or the menu.
Check that the menu at the menu
position (left beside the search box) is shown as expected with this PR applied.
Check that the look of all other things on the page has not changed after applying this PR.
See following picture with the menu marked with a red ellipse:
See following picture with the menu marked with a red ellipse:
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End Templates (site) |
@dgrammatiko @mbabker @brianteeman @ciar4n Do I also have to provide template.css and template.min.css with this PR? If so: Maybe someone can compile and minify the css for me and make a PR against my branch? I do not have the necessary environment here for that, and for my test I used other tools.
Sorry, this PR is wrong. I will make a new one soon.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-09 08:55:16 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
?
|
To compile and minify the SCSS you can run node build --compilecss
in your Joomla root.
This PR was wrong with removing the flex-column
class from the php, because the flex-column
is used as selector in the _header.scss.
Is there someone already working on BEM HTML class naming for mod_menu? If so, it would not make sense that I start with that in parallel. But if not, then I could try it.
@dgrammatiko @mbabker @brianteeman @ciar4n Do I also have to provide template.css and template.min.css with this PR? If so: Maybe someone can compile and minify the css for me and make a PR against my branch? I do not have the necessary environment here for that, and for my test I used other tools.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20700.