[#20676] - [4.0] Fix multiple sampledata
- Fixed in Code Base
- 6 Jun 2018
- Medium
- Build: staging
- # 20676
- Diff
- Bakual:FixMultipleSampledata
User tests: Successful: Unsuccessful:
Pull Request for Issue #20662
Summary of Changes
Adds a check to the sampledata JavaScript to ignore empty responses in the foreach loop.
I'm not sure what the current process is to generate the minimised JS files. Maybe @C-Lodder or @dgrammatiko can help here.
Testing Instructions
- Install the testing sampledata plugin (or any other one) from https://github.com/joomla-extensions/testing-sample-data/releases/tag/v3.8.0. That one is expected to be broken in 4.0 but for this test it will do.
- Try installing the "Blog Sample Data" from the Control Panel.
Expected result
Works
Actual result
A JS Error prevents more than one step executed. See original issue for screenshots.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin |
Yep should be towards 4.0 (staging is fine btw).
I did download the modified js file from the Bakual:FixMultipleSampledata branch and it now works fine.
Patch is adding
if (value === null) {
continue;
}
I'm not sure what the current process is to generate the minimised JS files.
Just run node build.js --compilejs in the root folder (assuming npm install was already executed before, to setup the dependencies)
Wrong branch??
Aw crap sure. I saw it but was to tired to remember bevore hitting the create button.
| Title |
|
||||||
| Category | Unit Tests Repository Administration com_admin | ⇒ | JavaScript |
generate the minimised JS files
| Labels |
Added:
?
?
|
||
Minifed file is updated as well now. Ready to test.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-06 21:32:26 |
| Closed_By | ⇒ | wilsonge |
LGTM! Thanks :)
Wrong branch??