? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
4 Jun 2018

Pull Request for Issue #20492.

Summary of Changes

Listing pages allow for multi-select except on the Templates page. This PR prevents the JS error when there are no checkboxes for multi-select.

Testing Instructions

install 4.0-dev
login to admin
go to template manager
click templates
click the image

See #20492 for video recording of error.

Expected result

No JS error

Actual result

JS error

multiselect.min.js?132339e72563fafc2a9b345f445e4d39:1 Uncaught TypeError: Cannot read property 'checked' of null

Documentation Changes Required

none

avatar Quy Quy - open - 4 Jun 2018
avatar Quy Quy - change - 4 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2018
Category JavaScript
avatar Quy Quy - change - 4 Jun 2018
Labels Added: ?
avatar ReLater ReLater - test_item - 4 Jun 2018 - Tested successfully
avatar ReLater
ReLater - comment - 4 Jun 2018

I have tested this item successfully on d4e2d76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20659.

avatar Quy Quy - change - 4 Jun 2018
The description was changed
avatar Quy Quy - edited - 4 Jun 2018
avatar brianteeman brianteeman - test_item - 4 Jun 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Jun 2018

I have tested this item successfully on d4e2d76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20659.

avatar Quy Quy - change - 4 Jun 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Jun 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20659.

avatar wilsonge wilsonge - close - 4 Jun 2018
avatar wilsonge wilsonge - merge - 4 Jun 2018
avatar wilsonge wilsonge - change - 4 Jun 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-04 21:41:25
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 4 Jun 2018

Thanks!

Add a Comment

Login with GitHub to post a comment