? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
2 Jun 2018

This is redo of #19635

This patch add <joomla-toolbar-button/> custom element, to standard toolbar button.
It allow us to move most of inline onclick="" to separate file.

Currently it only for StandardButton.

Testing Instructions

Click the toolbar buttons here and there, and make sure all works as expected, as before the patch.

ping @dgrammatiko @wilsonge

avatar Fedik Fedik - open - 2 Jun 2018
avatar Fedik Fedik - change - 2 Jun 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2018
Category JavaScript Repository Layout Libraries
avatar dgrammatiko
dgrammatiko - comment - 2 Jun 2018

@Fedik can you check Fedik#8

avatar Fedik Fedik - change - 2 Jun 2018
Labels Added: ? ?
avatar Fedik
Fedik - comment - 2 Jun 2018

@dgrammatiko thanks

avatar infograf768
infograf768 - comment - 3 Jun 2018

Did not remark any change in toolbar behavior after patch.

avatar wilsonge wilsonge - change - 13 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-13 12:05:49
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Jun 2018
avatar wilsonge wilsonge - merge - 13 Jun 2018
avatar wilsonge
wilsonge - comment - 13 Jun 2018

Awesome work! Thanks for being so patient with this one!

Add a Comment

Login with GitHub to post a comment