[#20596] - [com_fields] Language filter
- Closed
- 13 May 2019
- Medium
- Build: staging
- # 20596
- Diff
- SharkyKZ:com_fields_1
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #20593.
Summary of Changes
On multilingual sites custom fields are filtered by language only when current item has language property. Some items (e.g. user registration form) do not have language property. This PR enables filtering by current language on items which do not have language property.
Testing Instructions
See #20593.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
I see. Then can we hide language field in com_fields based on context?
Where do you want to hide it?
In com_fields whenever context doesn't support it.
Also, property mapped to core_language should be used instead of hardcoded language property.
This pr will bring some regressions for sure as you make the request then dependent of its environment. We were discussing the issue already in the past, but I can't remember the number or pr? Maybe @infograf768 can remember. I would close it because this is the wrong way to go. Better to define the language of the item in the model where build the form from.
closed as stated above.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-13 08:11:58 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Removed:
J3 Issue
|
||
My conclusion on this was
#18743 (comment)
We had once a similar pr #18743 which got closed, because we should not rely on the site language when fetching items.