[#20573] - [4.0] Preventing weight in Finder from locale formating
- Fixed in Code Base
- 14 Jun 2018
- Medium
- Build: 4.0-dev
- # 20573
- Diff
- Hackwar:patch-22
User tests: Successful: Unsuccessful:
Alternative PR for issue #17114. (Original PR: #17345)
When casting the weight as float, it seems PHP is using a locale aware method, which results in the number sometimes having the wrong decimal-separator and then the query fails. The weight already is formatted as a float with a dot as a decimal-separator, so it should be enough to simply quote this, as @csthomas wrote in the original PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20573.
In non-mysql does the mis-match (this will now be a string) cause an issue?
This is a common problem for all databases.
Take a look at joomla-framework/database#127 (comment) and these links.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-14 23:08:34 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 6834fc0
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20573.