? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 May 2018

The result layout of com_finder is very basic and the results of com_search leave a bigger impression. If we want all that information to be presented in the search results, is another question.

This PR reworks the result layout of com_finder to look more like those of com_search. I'm not happy with the current result myself, but I wanted to bring this up for discussion. What do you guys think? Should we rework this or rather not? Or rather just remove the URL below the result? (See #20571)

avatar Hackwar Hackwar - open - 24 May 2018
avatar Hackwar Hackwar - change - 24 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2018
Category Front End com_finder Plugins
avatar brianteeman
brianteeman - comment - 25 May 2018

I like the idea that both search components should have the same layout. This pr is close but still not identical

Search

chrome_2018-05-25_12-33-41

Smart search

chrome_2018-05-25_12-34-38

avatar Hackwar Hackwar - change - 28 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2018
Category Front End com_finder Plugins Front End com_finder
avatar carlitorweb
carlitorweb - comment - 18 Jun 2018

Well, I really not like the layout of com_search. I Like more the compact mode of com_finder, Title, Text and maybe the URL.
So, I test this PR and work ok, but not sure if this PR is more like an RFC or for add this reworking layout.

avatar Hackwar
Hackwar - comment - 18 Jun 2018

I will see what I can do to incorporate your comment @carlitorweb

avatar carlitorweb
carlitorweb - comment - 18 Jun 2018

Thank you :). Is just my opinion about it.

avatar carlitorweb
carlitorweb - comment - 27 Jun 2018

Some update for this one @Hackwar ?

avatar Hackwar
Hackwar - comment - 27 Jun 2018

I will. I just need some more time. The priority of this PR is rather low.

avatar carlitorweb
carlitorweb - comment - 27 Jun 2018

The priority of this PR is rather low.

Yes I know

avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2018
Category Front End com_finder Administration com_finder Language & Strings Front End
avatar Hackwar Hackwar - change - 1 Jul 2018
Labels Added: ?
avatar Hackwar
Hackwar - comment - 1 Jul 2018

I've updated this PR and consider this now feature-complete. I would call this an passable generalised result layout, which now can display the different taxonomies, the date of the item and the URL besides the title and the description. If somebody has a good solution to get a spacer between the search results, I'm all ears.

While implementing the taxonomies, it became apparent that we want to control which of these to display and which to hide. In theory the taxonomies support publish/unpublish states and even the access modifiers. However right now the taxonomies are stored inside the serialized FinderIndexerResult object and are not updated when retrieving the search results or when changing the taxonomies in the backend. Besides that, the taxonomies are lacking a GUI to modify the access modifiers. I plan to rework the taxonomies, too, and would address those issues there.

Happy testing.

avatar carlitorweb
carlitorweb - comment - 6 Jul 2018

BEFORE

screenshot_20180706091424

AFTER

screenshot_20180706091412

The highlighted word inside a badge no looks so good. My personal opinion, I hate that "highlight" stuff in a search result. For me, a clean result page as much as possible can be, is better for the user can find faster what they looking for.

A way I like to see a search results page is having, for example, something like this:

screenshot_20180706093417

Can be rows with 2 column or 3 depending on the layout.

avatar Hackwar
Hackwar - comment - 6 Jul 2018

@carlitorweb I agree sort of with you. This is definitely not the ultimate search result layout, but I guess it is the best compromise that we can have here. Anyway, thanks for testing. I will fix the conflict and then it would be nice if you could mark this as successfully tested. ?

avatar carlitorweb
carlitorweb - comment - 6 Jul 2018

This is definitely not the ultimate search result layout

I know buddy, just was sharing with you my thought. Waiting for the commit, for put the test.

avatar Hackwar
Hackwar - comment - 6 Jul 2018

Conflicts fixed.

avatar carlitorweb carlitorweb - test_item - 6 Jul 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 6 Jul 2018

I have tested this item successfully on 4dea366


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572.

avatar Quy
Quy - comment - 6 Jul 2018

I have tested this item successfully on 4dea366


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572.

avatar Quy Quy - test_item - 6 Jul 2018 - Tested successfully
avatar Quy Quy - change - 6 Jul 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Jul 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572.

avatar Hackwar
Hackwar - comment - 7 Jul 2018

Thank you!

avatar Hackwar Hackwar - change - 7 Jul 2018
Labels Added: ?
avatar Hackwar
Hackwar - comment - 7 Jul 2018

Fixed the conflict by the merge of #20681. Do we have to retest all of this or can we simply merge this?

avatar TobsBobs
TobsBobs - comment - 7 Jul 2018

screenshot_2018-07-07 home

avatar TobsBobs
TobsBobs - comment - 7 Jul 2018

I have tested this item successfully on b1787b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572.

avatar TobsBobs TobsBobs - test_item - 7 Jul 2018 - Tested successfully
avatar wilsonge wilsonge - change - 7 Jul 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-07 19:37:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 Jul 2018
avatar wilsonge wilsonge - merge - 7 Jul 2018
avatar wilsonge
wilsonge - comment - 7 Jul 2018

Thanks :)

Add a Comment

Login with GitHub to post a comment