? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
22 May 2018

Pull Request for Issue #20531

Summary of Changes

Modules don't have $this context, so can't call $this->escape(). Escape output using htmlspecialchars() instead.

Testing Instructions

Apply patch, make sure module works again.

Expected result

Module shows an image.

Actual result

Module causes a fatal error.

Documentation Changes Required

Somewhere in the security team's testing and review workflow there probably does need to be a change...

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar mbabker mbabker - open - 22 May 2018
avatar mbabker mbabker - change - 22 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2018
Category Modules Front End
avatar carlitorweb
carlitorweb - comment - 22 May 2018

I have tested this item successfully on a1c8826

screenshot_20180522114133


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
avatar carlitorweb carlitorweb - test_item - 22 May 2018 - Tested successfully
avatar david-bettondesign
david-bettondesign - comment - 22 May 2018

I have tested this item successfully on a1c8826


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.

avatar david-bettondesign david-bettondesign - test_item - 22 May 2018 - Tested successfully
avatar PhilETaylor PhilETaylor - comment - 22 May 2018
avatar PhilETaylor PhilETaylor - test_item - 22 May 2018 - Tested successfully
avatar zero-24
zero-24 - comment - 22 May 2018
avatar schildmi
schildmi - comment - 22 May 2018

Perfect work! Thanks a lot!

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 May 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 May 2018

Ready to Commit after 3 successful tests.

avatar GASOLINE
GASOLINE - comment - 22 May 2018

I had same issue. Nice to see it's already identified.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.

avatar GASOLINE
GASOLINE - comment - 22 May 2018

I applied the suggested change and can confirm it works. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.

avatar GASOLINE
GASOLINE - comment - 22 May 2018

I applied the suggested change and can confirm it works. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.

avatar wilsonge wilsonge - change - 22 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-22 17:17:58
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 22 May 2018
avatar wilsonge wilsonge - merge - 22 May 2018
avatar wilsonge
wilsonge - comment - 22 May 2018

Merged. Thanks everyone involved!

avatar tigi
tigi - comment - 22 May 2018

I have tested this item successfully on a1c8826

I had the same problem and the patch solved it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.

avatar tigi tigi - test_item - 22 May 2018 - Tested successfully
avatar Hotkeyharry
Hotkeyharry - comment - 25 May 2018

I have tested this item successfully on a1c8826
I had the same problem and the patch solved it.

avatar 10john
10john - comment - 27 May 2018

Search articles no longer works after Upgrade

avatar PhilETaylor
PhilETaylor - comment - 27 May 2018

@10john "Searching articles" is nothing to do with this issue you commented on, if you have an issue that you believe is a real bug then please open a new issue with FULL details.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 May 2018

@10john you can also ask help on the forums as this repository concerns in first Place Joomla-Core coding, thanks.

avatar admiralsmaster admiralsmaster - test_item - 19 Jun 2018 - Tested successfully
avatar admiralsmaster
admiralsmaster - comment - 19 Jun 2018

I have tested this item successfully on a1c8826

Successful tested.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.

Add a Comment

Login with GitHub to post a comment