[#20533] - Correctly escape the random image module output
- Fixed in Code Base
- 22 May 2018
- Medium
- Build: staging
- # 20533
- Diff
- joomla:fix/random-image-module
- Pending continuous-integration/travis-ci/push The Travis CI build is in progress Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Success continuous-integration/drone/push the build was successful Details
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #20531
Summary of Changes
Modules don't have $this context, so can't call $this->escape(). Escape output using htmlspecialchars() instead.
Testing Instructions
Apply patch, make sure module works again.
Expected result
Module shows an image.
Actual result
Module causes a fatal error.
Documentation Changes Required
Somewhere in the security team's testing and review workflow there probably does need to be a change...
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
PhilETaylor
- 
Initial FAQ Entry page created: https://docs.joomla.org/J3.x:Module_random_image_PHP_Error_after_3.8.8
Perfect work! Thanks a lot!
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after 3 successful tests.
I had same issue. Nice to see it's already identified.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
I applied the suggested change and can confirm it works. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
I applied the suggested change and can confirm it works. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-22 17:17:58 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Merged. Thanks everyone involved!
I have tested this item
I had the same problem and the patch solved it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
Search articles no longer works after Upgrade
I have tested this item
Successful tested.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.
I have tested this item✅ successfully on a1c8826
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20533.