[#20509] - add a HTML width element to the image in the RSS feed
- Closed
- 21 May 2018
- Medium
- Build: staging
- # 20509
- Diff
- uglyeoin:patch-10
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
As RSS is commonly used in Email clients we can limit the width of the image. This will mean the images do not blow the width of emails in Outlook with the original image width - which potentially could be 1200 (or more if retina images are used). Emails are generally no more than 640 pixels wide.
Pull Request for Issue # .
Summary of Changes
Max image width will be 640px
Testing Instructions
Check RSS feed and see if image width is set. You probably need to view source in your browser.
Expected result
Image has a width of 640 added as a HTML element
Actual result
No width is forced making people scroll left/right in their browsers
Documentation Changes Required
n/a
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Title |
|
||||||
It could increase the size of some images too, yes. But there is really no way to avoid that due to the limitations of emails. For example you can use max-width in a style attribute but Outlook will ignore it.
It would increase the size of every single image on my blog from 240px to 640px - so this really is not a solution that can apply to the core of joomla as it breaks sites
It does not break sites, it is only applied to the feed. You could argue it breaks feeds, but they are used in a totally different way to sites. This pull request is solely aimed at feeds, which are commonly used in emails.
yes it completely breaks the feed from my site and any web site that includes that feed
Hmm, ok, back to the drawing board. I'll test a little further. To be fair, I suspect this code is pretty old and could do with a bit of a bigger overhaul.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-21 10:27:54 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
Surely this would also INCREASE the size of the images as well