Cannot replicate

oops pressed the wrong button

can not replicate

There is PR for this (although WIP, as we haven't decided yet the actual API): #19830

but this should work until the modals are redone.

So here is the actual situation: we removed the moo tools code and effectively the method jModalClose. We need a replacement for it and although it is painful to see things break, it is far more wise to get the API correctly for the entire life of J4.

Other modals are closing ok - so there should be an easy fix to close this modal... like the others.

Not true, switch to codemirror and observe that none of the modals actually close. Anyways alpha is not about quick fixes, as I said the API needs to be the best we can provide as it's gonna last for the entire life of J4

#19830 is still open once this get's merged all modals will be fixed, The PR you mentioned was the one that ended up breaking because I was solving too many issues at one pr.

We can't keep applying bandaid quick fixes to keep something usable until its replacement is fully ready, we don't have the time or resources to be doing that. We know it's broken, we know what the replacement is, help test/review said replacement so the issue gets fixed, or look for the dozen or so of us working on all these things to have less time to spend on things because we're working on bandaid quick fixes.

Closing this as it will be resolved by #19830