Feeling Lucky
[#2048] - [#32073] Change +1 to 1
- Closed
- 22 Sep 2013
- Medium
- Build: master
- # 2048
- Diff
- mbabker:plusOnes
- Foreign ID 32073
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
User tests: Successful: Unsuccessful:
garyamort
-
Reviewed the patch proposed, and from a coding point of view, it is a no-brainer: OK
Btw, same commit included more code cleanups than the fix itself (spacings and removal of obsolete commented code).
Nothing major: It would simplify code reviews when a simple change isn't burried in even more spacing cleanups. ;-)
Best practice is to have separate commits for cleanups (and label them "code cleanup"). ;-)