J4 Issue ?
avatar PhilETaylor
PhilETaylor
15 May 2018

Steps to reproduce the issue

also see #20417 and
#20241 - about com_content not only about opening preview in a new window
#20240 - for j3.x Although I will not oppose its closure. If this is realized in j4.


#20417 implements the code to allow the preview button when editing an article in admin to be either a model or new window (target=_blank).

This is the first half of this job.

The code to support the above feature in the Toolbar trait is now done.

The next part is to find a place to have a toggle for

Open the preview in a "model" or "new window"

when clicking the preview button.

I guess the right place is here?

screen shot 2018-05-15 at 22 46 23

once the "right place" has been found for this toggle, the toggle can be added, and then the implementation of that selected value can be used as a bool when calling the toolbar preview link in

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/View/Article/HtmlView.php#L183

avatar PhilETaylor PhilETaylor - open - 15 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 May 2018
avatar PhilETaylor PhilETaylor - change - 15 May 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 15 May 2018
avatar PhilETaylor PhilETaylor - change - 15 May 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 15 May 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 May 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 May 2018
Category com_content UI/UX
avatar brianteeman brianteeman - change - 16 May 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 16 May 2018
avatar Septdir
Septdir - comment - 19 May 2018

Please add [com_content] tag to title.

@PhilETaylor

I guess the right place is here?

Here or in Integration tab

avatar PhilETaylor PhilETaylor - change - 19 May 2018
Title
[4.0] Ability to toggle the preview button to be a modal or a new tab/page
[4.0] [com_content] Ability to toggle the preview button to be a modal or a new tab/page
avatar PhilETaylor PhilETaylor - edited - 19 May 2018
avatar Septdir
Septdir - comment - 11 Jun 2018

#20417 Merged

avatar brianteeman
brianteeman - comment - 15 Jun 2018

yes this screen would be the right place to add yet another option

avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:34:10
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment