#20241 - about com_content not only about opening preview in a new window
#20240 - for j3.x Although I will not oppose its closure. If this is realized in j4.

Need Testing Instructions

I have tested this item ✅ successfully on 63edb82

I have tested this item ✅ successfully on 63edb82

@PhilETaylor resolve the branch conflict and will be ready

RTC

Please retest.

I have tested this item ? unsuccessfully on 163b396

			\JLoader::register('ContentHelperPreview', JPATH_ADMINISTRATOR . '/components/com_content/helpers/preview.php');
				$url = \ContentHelperPreview::url($this->item);
				$toolbar->preview($url, \JText::_('JGLOBAL_PREVIEW'))
					->bodyHeight(80)
					->modalWidth(90);

				$toolbar->preview($url,'New window', true); // NEW- target=_blank link button
				$toolbar->preview($url,'always modal', false); // like its always been = modal
				$toolbar->preview($url,'old'); // like its always been = modal

Add two buttons New window (test in com_content)

This code

if ($newWindow === true)
		{
			$button = $this->linkButton('link', $text)
				->url($url)
				->attributes(['target' => '_blank'])
				->icon('icon-eye');
		}
		else
		{
			$button = $this->popupButton('preview', $text)
				->url($url)
				->iframeWidth(640)
				->iframeHeight(480)
				->icon('icon-eye');

		}

This code will work correctly (I checked)

I have tested this item ✅ successfully on 710e542

Now work correct

I have tested this item ✅ successfully on 710e542

@PhilETaylor happens to all ;)

RTC

I meant it like that (else is not necessary).. (Just as a note for future PRs)

if ($newWindow === true)
{
	return $this->linkButton('link', $text)
		->url($url)
		->attributes(['target' => '_blank'])
		->icon('icon-eye');
}

return $this->popupButton('preview', $text)
	->url($url)
	->iframeWidth(640)
	->iframeHeight(480)
	->icon('icon-eye');

@yvesh then we can write so

return $newWindow === true ? $this->linkButton('link', $text)->url($url)->attributes(['target' => '_blank'])->icon('icon-eye')
	: $this->popupButton('preview', $text)->url($url)->iframeWidth(640)->iframeHeight(480)->icon('icon-eye');

P.S personally I do not like very much when return gets a few lines. Or two identical. IMHO It's better to return a variable.

@PhilETaylor that's why i wrote "for the next PR" :-)

And this is not on preference, else is considered bad style when it can be avoided. (Just google avoid else, return early.. thousands of articles on it).

And it is not meant as critics, it was just a well-intentioned suggestion to improve further..

early return as suggested is not a Code Style preference, is much more a documented "tecnique" to write more clean&manageable code "Object Calisthenics" ...

it wasn't my intention to discourage contributions...
i'm sorry if you felt that way

challenge accepted see joomla/coding-standards#236

@PhilETaylor i know what you mean, and i've experienced that feelings quite sometimes, but if all of us give up ?...
at least i can tell that i've tried ?
https://www.youtube.com/watch?v=tCZxGG_4ins

I like if/else.much more readable.

Thanks @PhilETaylor to make J4 great.