[#20393] - [4.0] Move javascript to be inline
- Fixed in Code Base
- 2 Jul 2018
- Medium
- Build: 4.0-dev
- # 20393
- Diff
- joomla:fix/javascript-jdocument
- Pending continuous-integration/drone/push this build is pending Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Move javascript to enqueue through JDocument and convert from jquery to native js (@dgrammatiko i did something maybe good?)
To test: Ensure that when you have multiple 2FA plugins installed you can swap between them successfully
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Labels |
Added:
?
|
||
| Title |
|
||||||
Should this not be moved to a script to remove inline at all? At least that's what we did in the ES6 repo too.
It's not a big deal either way. This was the minimum required for the CSP work we were doing at the JSST sprint.
Still would be good to have it as its own script like we did with others. To keep consistency.
| Category | Front End com_users | ⇒ | Front End com_users JavaScript |
OK So I moved it to a standalone file. But looks like there's some sort of bug because the es6 files don't run through babel (I can't see anywhere where the es6 compiler is even called in build.js)
@dgrammatiko can you please ensure that we are actually running babel on the es6 files - bit of an issue if we are not!
Ok, I assume you saw the two commands. Then we need the help of @dgrammatiko.
OK got there in the end.
Javascript is fun! Nobody said that in 2018...
Are the failing system tests related to this pr?
Drone was there green.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-02 22:31:14 |
| Closed_By | ⇒ | laoneo |
So I'm going to merge this one.
updated the title