? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
10 May 2018

You can test the different kinds of errors. All errors messages now use the JFactory enqueued messages rather than a extra message field. Technically we now handle the case the server spits out an exception (error is true) although I don't know how this would happen.

Finally we now get errors specific to the db property failing being rendered. You can test the following things:

  1. Enter an invalid DB prefix (add an invalid character like an exclamation mark) - you'll get the Check your DB credentials, db type, db name or hostname string for form validation failure as well as the specific db prefix string (I've restored the Joomla 3 one which seemed to have been deleted along the way despite it's being used in 3 different places)

  2. Enter an invalid password. The error message will show up with a more specific error than currently

e.g.

Could not connect to the database. Connector returned number: Could not connect to MySQL: Access denied for user 'root'@'localhost' (using password: YES)

(yes the message is kinda grim reading but this is the INSTL_DATABASE_COULD_NOT_CONNECT string - this can be refined in the future for sure :)

  1. Obviously test the happy installer path continues to work
avatar wilsonge wilsonge - open - 10 May 2018
avatar wilsonge wilsonge - change - 10 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2018
Category Installation Language & Strings JavaScript
avatar wilsonge wilsonge - change - 10 May 2018
Labels Added: ? ?
avatar laoneo laoneo - change - 7 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-07 05:52:16
Closed_By laoneo
avatar laoneo laoneo - close - 7 Aug 2018
avatar laoneo laoneo - merge - 7 Aug 2018
avatar laoneo
laoneo - comment - 7 Aug 2018

Worked as expected. Thanks.

avatar wilsonge
wilsonge - comment - 7 Aug 2018

Thanks!

avatar dgrammatiko
dgrammatiko - comment - 7 Aug 2018

@wilsonge @laoneo can we apply the same idea for all errors in the installation app ?

avatar wilsonge
wilsonge - comment - 7 Aug 2018

Probably - my main aim here was to remove the messages property - which isn't used by the rest of the InstallationController https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Controller/InstallationController.php

avatar laoneo
laoneo - comment - 7 Aug 2018

Do we need first the promise based set up?

avatar dgrammatiko
dgrammatiko - comment - 7 Aug 2018

@laoneo good question, let me finish the monkey work with the es6 scripts and then I 'll spend some time on this "promise land"...

Add a Comment

Login with GitHub to post a comment