? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
3 May 2018

Pull Request for Issue # .

Summary of Changes

Command $ node build.js --compilejs is required after update

Also added some doc block in the build.js:

/**
 * Command line helper
 *
 * For maintainers, please run:
 * node build.js --installer
 * node build.js --update
 * node build.js --compilejs
 * node build.js --compilecss
 * Before making any PRs or building any package!
 * 
 */

Update:
updated the commands: npm i and node run update so they'll all the neccessary steps

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@C-Lodder this is a fix for #20290
@wilsonge please review and merge

avatar dgrammatiko dgrammatiko - open - 3 May 2018
avatar dgrammatiko dgrammatiko - change - 3 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2018
Category JavaScript
avatar dgrammatiko dgrammatiko - change - 3 May 2018
The description was changed
avatar dgrammatiko dgrammatiko - edited - 3 May 2018
avatar dgrammatiko dgrammatiko - change - 3 May 2018
The description was changed
avatar dgrammatiko dgrammatiko - edited - 3 May 2018
avatar dgrammatiko dgrammatiko - change - 3 May 2018
Labels Added: ?
avatar dgrammatiko dgrammatiko - change - 3 May 2018
The description was changed
avatar dgrammatiko dgrammatiko - edited - 3 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2018
Category JavaScript Administration Templates (admin) JavaScript Repository
avatar wilsonge wilsonge - change - 3 May 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-03 23:11:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 May 2018
avatar wilsonge wilsonge - merge - 3 May 2018

Add a Comment

Login with GitHub to post a comment