No Code Attached Yet J3 Issue Information Required
avatar ciar4n
ciar4n
29 Apr 2018

Steps to reproduce the issue

Navigate to Components -> Smart Search
Scroll down so toolbar sticks
Click 'Index'

Expected result

Modal appears above backdrop

Actual result

Modal appears behind backdrop

image

System information (as much as possible)

Additional comments

avatar ciar4n ciar4n - open - 29 Apr 2018
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Apr 2018
avatar ciar4n ciar4n - change - 29 Apr 2018
The description was changed
avatar ciar4n ciar4n - edited - 29 Apr 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Apr 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Apr 2018
Category com_search JavaScript
avatar brianteeman brianteeman - change - 28 May 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 28 May 2018
avatar Quy
Quy - comment - 4 Oct 2018

PR #22367 produces this issue. It was ok in beta3 but not in beta4.

avatar ciar4n
ciar4n - comment - 4 Oct 2018

That would mean it was fixed since the issue was created and broke again with #22367 ?

avatar Quy
Quy - comment - 4 Oct 2018

Yes that appears to be the case. I replaced the affected files in #22367 from beta3 and the issue was fixed.

avatar ciar4n
ciar4n - comment - 4 Oct 2018

The issue was gone before and after scrolling?

avatar Quy
Quy - comment - 4 Oct 2018

I’m not at my computer to confirm. I will check later today.

avatar infograf768
infograf768 - comment - 4 Oct 2018

My test here show that the modal is indeed dark (in fact the page itself is darkened and the modal is beneath) but the indexing is done and then the modal auto-close.

avatar Quy
Quy - comment - 4 Oct 2018

@infograf768 Can you test with beta3? Be sure to scroll down the page until the toolbar sticks at the top and then click the index button.

avatar infograf768
infograf768 - comment - 4 Oct 2018

The point is that with staging I do not need to scroll at all. The issue happens whatever the size of the window and no scroll.
Will try to get a beta3.

avatar ciar4n
ciar4n - comment - 4 Oct 2018

Please read.. #22465 (comment)

avatar infograf768
infograf768 - comment - 4 Oct 2018

beta3 => same issue!!!

avatar ciar4n
ciar4n - comment - 4 Oct 2018

Yes this issue has always been present. @Quy s original issue (#22465) is only since beta 4.

avatar infograf768
infograf768 - comment - 4 Oct 2018

Well, it has not always been present. It was working OK in 3.8.12...

avatar ciar4n
ciar4n - comment - 4 Oct 2018

No, this was always an issue. And will remain an issue even if #22367 is reverted. #22465 is a separate issue and is only present since 3.9 beta4.

avatar infograf768
infograf768 - comment - 4 Oct 2018

I disagree. I just installed a clean 3.8.12 and the modal displays fine OVER the backdrop.
(Macintosh, Firefox)
modalissue

avatar ciar4n
ciar4n - comment - 4 Oct 2018

And is the issue present if you scroll first then open the modal (as stated in the description)?

avatar infograf768
infograf768 - comment - 4 Oct 2018

In staging, scrolling or not scrolling is unimportant.
As I said above, the modal is hidden behind the backdrop.
The issue is unrelated to scrolling.
Tested also with scrolling in 3.8.12 and it is also unrelated. It works in both cases.

avatar infograf768
infograf768 - comment - 4 Oct 2018

I consider this as a non B/C situation. A 3rd party extension could be displaying a modal this way where informations have to be entered.

avatar ciar4n
ciar4n - comment - 4 Oct 2018

Sighs...

Navigate to Components -> Smart Search
Scroll down so toolbar sticks
Click 'Index'

This issue is everything related to scrolling. This issue was only present after scrolling. Open 3.8.12 and follow the above. I repeat...

#22465 is a separate issue and is only present since 3.9 beta4.

avatar infograf768
infograf768 - comment - 4 Oct 2018

In fact, you are right when there are already indexes in the page.
When indexes have been cleared, no issue after scrolling, as you can see below (3.8.12).

modalissue2

I indeed never tested Indexing when the list contains some stuff. I systematically clear Index before indexing...

EDIT: same situation in staging.
EDIT2: The difference in staging seems that it is also broken when NOT scrolling.

avatar infograf768
infograf768 - comment - 4 Oct 2018

This to show that the issue in staging happens when NOT scrolling at all and list empty.

modalissue3

avatar ciar4n
ciar4n - comment - 4 Oct 2018

Thank you for confirming.

Both this issue and #22465 are somewhat related in that they are both caused by anything other than position:static applied to the toolbar. Prior to #22367 this was only after scrolling.

avatar infograf768
infograf768 - comment - 4 Oct 2018

Shall we therefore consider reverting #22367 if it at least solves the issue when not scrolling, or do we have a better solution?

avatar ciar4n
ciar4n - comment - 4 Oct 2018

I think so. Unless someone can fix how modals are rendered (unlikely at this stage), the only solution, as I see it, is to revert #22367.

avatar ciar4n
ciar4n - comment - 4 Oct 2018

Note.. reverting won't fix this issue, but will fix #22465

avatar ciar4n
ciar4n - comment - 4 Oct 2018

When I say fix, rendering the modal anywhere outside of the subhead div should do it (eg. Batch modal in com-content)

avatar infograf768
infograf768 - comment - 5 Oct 2018

For finder we have

		$toolbar->appendButton(
			'Popup', 'archive', 'COM_FINDER_INDEX', 'index.php?option=com_finder&view=indexer&tmpl=component', 500, 210, 0, 0,
			'window.parent.location.reload()', 'COM_FINDER_HEADING_INDEXER'
		);

For batch, we have

$toolbar->popupButton('batch')
				->text('JTOOLBAR_BATCH')
				->selector('collapseModal')
				->listCheck(true);

Also, the issue does not only concern Indexed Content but also the Statistics button in this view as in the other finder views (Maps & Search Filters)

$toolbar->appendButton('Popup', 'bars', 'COM_FINDER_STATISTICS', 'index.php?option=com_finder&view=statistics&tmpl=component', 550, 350);
avatar infograf768
infograf768 - comment - 5 Oct 2018

@Hackwar
Any way to modify the code for these Toolbar buttons?

avatar infograf768
infograf768 - comment - 5 Oct 2018

Revert PR is ready here
#22506

avatar jwaisner jwaisner - change - 18 Mar 2020
Status Discussion Information Required
avatar jwaisner
jwaisner - comment - 18 Mar 2020

@ciar4n Can you confirm after the revert PR that this issue is fixed?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20255.

avatar Harmageddon
Harmageddon - comment - 18 Mar 2020

@jwaisner As noted above (#20255 (comment)), the revert only fixed the issue for scenarios when you don't scroll. When scrolling down (so the toolbar becomes sticky), the issue still exists in v3.9.16.

avatar jwaisner jwaisner - change - 19 Mar 2020
Priority Medium Low
Status Information Required Confirmed
avatar Hackwar
Hackwar - comment - 28 Dec 2021

Is this still an issue? I can't replicate this on J4 in Smart Search.

avatar Quy Quy - change - 1 Feb 2022
Labels Added: No Code Attached Yet Information Required
Removed: ?
avatar Quy Quy - labeled - 1 Feb 2022
avatar Quy
Quy - comment - 4 Feb 2022

It is still reproducible in J3, but probably not worth fixing as it does not affect the indexing. @zero-24 close?

avatar Quy
Quy - comment - 15 Aug 2022

Closing as there are no more J3 releases other than security fixes. Not an issue in J4.

avatar Quy Quy - change - 15 Aug 2022
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2022-08-15 13:43:27
Closed_By Quy
avatar Quy Quy - close - 15 Aug 2022

Add a Comment

Login with GitHub to post a comment