Within UsersModelUser::getForm()
there is logic for the send mail to users plugin capability that is hardcoded to only support that plugin. Either this capability should be fully moved to the plugin (meaning the form alterations should happen via plugin event) or be fully moved to the component (meaning the mail sending code exists in the component).
Labels |
Added:
?
|
Status | New | ⇒ | Discussion |
Category | ⇒ | com_plugins com_users |
The safest plan would be to move the logic from the component to the plugin and use the plugin events to modify the form (that wouldn't be a B/C break by any sane definition) instead of moving the feature support from the plugin to the component (which probably gets into B/C concerns because it means configuration checking needs to account for both the existing plugin config and a new component config value).
I hate every time something needs the safest plan (joke).
Well, then if make the plugin modify the form for set as required the password field, for avoid B/C breaks, then, will be good make another PR to J4, moving all the logic to the component (this, because I think is the right place for this code). Is a good plan?
I wouldn't put it in the component. With a plugin driven approach it's possible to use a different email (once the hard coupling is in place), given the lack of events in our email sending process the next best thing is leaving this in the plugin and letting someone write another plugin with a different email (or logic around sending it) if they want to customize it any.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-01 18:15:03 |
Closed_By | ⇒ | joomla-cms-bot |
Closed_By | joomla-cms-bot | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/20249
I on it, in my opinion, this need be inside the component. But this will create a b/c compatibility right?