[#20209] - Fix subform.repeatable-table multi field styling
- Fixed in Code Base
- 21 Jul 2018
- Medium
- Build: staging
- # 20209
- Diff
- ciar4n:subform-style
User tests: Successful: Unsuccessful:
Pull Request for Issue #17589 (comment) .
Summary of Changes
Fixes subform.repeatable-table styling when multiple fields are placed in the same cell.
Before PR
After PR
Testing Instructions
Add the following after https://github.com/joomla/joomla-cms/blob/staging/modules/mod_login/mod_login.xml#L26
<field name="sebform1" type="subform" label="subform"
layout="joomla.form.field.subform.repeatable-table" multiple="true" groupByFieldset="true">
<form>
<fieldset name="group1" label="group 1">
<field type="text" name="text" label="text 1"/>
<field type="text" name="text2" label="text 2"/>
<field type="text" name="text3" label="text 3"/>
</fieldset>
<fieldset name="group2" label="group 2">
<field type="text" name="text4" label="text 4"/>
<field type="textarea" name="textarea" label="textarea"/>
</fieldset>
</form>
</field>
Open login module settings. Check repeatable field styling.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I assume this is not related .btn-group > .btn:first-child, .radio.btn-group > label:first-of-type, but ok to delete.
Appears there is a difference between the LESS and compiled CSS in staging. Either some file not previously committed or files edited directly.
| Labels |
Added:
?
|
||
Do you still need to add .btn-group > .btn:first-child, .radio.btn-group > label:first-of-type even though it is here already?
joomla-cms/media/jui/less/bootstrap-rtl.less
Lines 114 to 129 in 49e681f
Do you still need to add .btn-group > .btn:first-child, .radio.btn-group > label:first-of-type even though it is here already?
@Quy We shouldn't however that less is been overridden elsewhere. Appears to be some cascading issues in the RTL CSS. I'll leave it for a separate PR. I've brought this PR back to the original and is now ready. The .btn-group > .btn:first-child, .radio.btn-group > label:first-of-type been removed here is due to the LESS not been compiled in a previous PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20209.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20209.
I tested it and after applying patch it looks like that:
@coolcat-creations A separate issue that is reported here.. #20210
As stated in that issue I was gonna fix once this got merged........
Hm before and after patch I have the same (good) layout... Tried with clearing cache etc but it looks always good...
@coolcat-creations Please use browser inspector on the 1st input field to see its CSS. The margin-bottom is 0. What is your value?
.form-search input, .form-search textarea, .form-search select, .form-search .help-inline, .form-search .uneditable-input, .form-search .input-prepend, .form-search .input-append, .form-inline input, .form-inline textarea, .form-inline select, .form-inline .help-inline, .form-inline .uneditable-input, .form-inline .input-prepend, .form-inline .input-append, .form-horizontal input, .form-horizontal textarea, .form-horizontal select, .form-horizontal .help-inline, .form-horizontal .uneditable-input, .form-horizontal .input-prepend, .form-horizontal .input-append {
display: inline-block;
*display: inline;
*zoom: 1;
margin-bottom: 0;
vertical-align: middle;
}
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20209.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20209.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-21 01:04:43 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 1aa3ba1
I assume this is not related
.btn-group > .btn:first-child, .radio.btn-group > label:first-of-type, but ok to delete.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20209.