Pending

User tests: Successful: Unsuccessful:

avatar NickSdot
NickSdot
21 Apr 2018

Pull Request for Issue #20207.

Summary of Changes

setComponent() and setClient() in \Joomla\CMS\Layout\FileLayout now using clearIncludePaths() instead of $this->refreshIncludePaths()

Testing Instructions

  1. Use LayoutHelper::render() to render a layout.
  2. Check your deprecated log before and after the patch is applied.
  3. Functionality should stay the same, but now without deprecated message in log.

Expected result

No more message 'FileLayout::refreshIncludePaths is deprecated, use FileLayout::clearIncludePaths() instead.' in /logs/deprecated.php

Actual result

Message 'FileLayout::refreshIncludePaths is deprecated, use FileLayout::clearIncludePaths() instead.' in /logs/deprecated.php

Documentation Changes Required

No.

avatar NickSdot NickSdot - open - 21 Apr 2018
avatar NickSdot NickSdot - change - 21 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2018
Category Libraries
avatar mbabker
mbabker - comment - 21 Apr 2018

This change has already been proposed and reverted in 3.x because changing the method calls breaks subclasses expecting their overridden methods to be called. See #13164 for additional context.

It is already addressed in 4.0 and cannot be patched in 3.x due to B/C.

avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2018
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 21 Apr 2018
avatar Quy Quy - change - 21 Apr 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-04-21 09:34:28
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 21 Apr 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20208

Add a Comment

Login with GitHub to post a comment