[#20170] - [4.0] Make categories use an interface
- Closed
- 6 May 2018
- Medium
- Build: 4.0-dev
- # 20170
- Diff
- wilsonge:fix/categories-using-interface
User tests: Successful: Unsuccessful:
- No hardcoding namespaces in the provider - grab them from the db so there's a single point of truth
- Use a feature interface for categories with an exception interface
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_fields Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Administration com_content com_fields Libraries | ⇒ | Administration com_associations com_content com_fields Libraries |
While rewriting #19843 (which is a similar pr) I'v discovered one issue you were raising in the last meeting as well. It looks awkward when an extension is implementing AssociationAwareInterface and at the same time a AssociationsNotImplementedException exception can be thrown. I know code wise it is correct, but from a logical point of view it is questionable if this is really the way to go.
That's why I made #20127 which showcases a generic service locator. The big drawback on that approach is that we do not have typed return values anymore.
It looks awkward when an extension is implementing AssociationAwareInterface and at the same time a AssociationsNotImplementedException
I agree - it's just the price of supporting the legacy implementation. I discussed this at length with Nic in Holland and the eventual outcome was it was less painful to have the exception than to loose the typehint (as the exception can easily be removed in j5 or whatever - but modifying an interface is a hard b/c break)
Don't think so it is a BC break problem. It reveals the problems when one extension is supporting associations and another not and both are using the default Component service provider.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-06 17:24:53 |
| Closed_By | ⇒ | wilsonge |
Changed Title to be clear its about 4.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20170.