[#20169] - [mod_articles_news] Option Intro/Full Images of the article
- Fixed in Code Base
- 28 May 2018
- Medium
- Build: staging
- # 20169
- Diff
- carlitorweb:mod_article_news_img_option
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19599 , #16495
Summary of Changes
Option to use or not, the intro image field or the full image field of the article
Testing Instructions
- Go to Extensions ->Modules and create a new Articles - Newsflash
- Put Show Images option, for any of the 3 options that list. Also, configure the module to display correctly in some position of the template
- Go to Content -> Articles, and use in one of the articles that the module will show, any of the fields "Intro image" or "Full article image"
- Go to the frontend, and check depending on the option that you put in the module, it shows or not, the image correctly
Expected result
The module shows or not, the fields "Intro image" or "Full article image" of the article correctly
Actual result
The current option only display images in the article context.
Documentation Changes Required
New module option added.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Labels |
Added:
?
|
||
You're very welcome. For reference, read Coding Standards Manual.
please remove the RTC status as this PR is not backwards compatible and it also changes the way that the module works
Issue 1
Create an article with an image INSIDE the article
create a newsflash module and set the show images to NO
Test and you will see that there are no images displayed
Apply this PR and do NOT change anything in the module
Check the module on the front end and you will see that images ARE displayed
Issue 2
There is no longer a way to not display images that are INSIDE the article
The no image option only stops the display of intro and full images
the intro image option will display the images INSIDE the article and the intro image
The full image option will display the images INSIDE the article and the full image
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
| Status | Ready to Commit | ⇒ | Pending |
@brianteeman Status is back on Pending by @Quy at Issue Tracker but Label "RTC" on Github is shown, can't remove it here.
@franz-wohlkoenig if a status is changed on the issue tracker it will be updated on github but only when a comment is made. Your comment triggered the change. So in future if a change is made on the issue tracker you should always make a comment explaining that yu made the change and then it will work here on github too
thanks Brian, so its vica versa working to set RTC and wrote here > haven't thought about it :-
@brianteeman the issue you talk about is more related to the user context than the module. Why need the module remove any image you put INSIDE the article? If I want my article to have or not an image in the introtext, then I just put it or not, INSIDE the introtext.
Anyway, can be another param asking for this, in case the user wants also, show or not, the image INSIDE the article
Also, in my opinion, I think the option to put an image that belongs to the text of the article, is an option only a few users use it.
- Unless you have a magic ball you can not know how many people use the current options
- You have to consider backwards compatibility. You can not make a change that will effect the display of millions of web sites
No, I do not have a magic ball, that is why I wrote "in my opinion", just counting with my small knowledge about this option.
Ok, what I will do is, revert the change, and make a new param leaving the old intact. In this way, we are only adding a new option to the module, without modifying it
| Labels |
Removed:
?
|
||
I revert the change. Now, this option is with a new param. Also, I modify the description for the old one, trying to avoid confusion, if is possible change this description.
Thank you
You welcome @brianteeman
B/C images all fixed now.
I think it would be best if you updated the old string "Show Images" to "Show article images" or something like that - just so that people dont think it is related to the other options below
Is true. Done. Thank you again.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
Ok done. Hope is better now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-28 14:59:22 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
Removed: ? |
||
Please help (my Joomla's up to date):
The Article-Newsflash Module doesn't show the Intro or Full image, as offered in the field.
What I found out - sorry, I'm not a programmer:
In the options field there's an english-german language mixup - see the screenshot:
http://www.schultz-hamburg.de/joomla-newsflash.png
Doesn't the module find the appropriate value?
I couldn't find the file where the values are translated and assigned to the corresponding keys.
I only found the german translation file de-DE_mod_articles-news_ini where the following lines are missing:
MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_DESC="... german translation ..." MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_LABEL="... german translation ..."
This is not a big issue, it's only the translation of the label and the description - so I tried and added it on my site. Of course, it didn't help with the bug.
Thanks for your patience!
Is done, thank you @Quy