? ? ?

Pending

User tests: Successful: Unsuccessful:

avatar carlitorweb
carlitorweb
14 Apr 2018

Pull Request for Issue #19599 , #16495

Summary of Changes

Option to use or not, the intro image field or the full image field of the article

Testing Instructions

  1. Go to Extensions ->Modules and create a new Articles - Newsflash
  2. Put Show Images option, for any of the 3 options that list. Also, configure the module to display correctly in some position of the template
  3. Go to Content -> Articles, and use in one of the articles that the module will show, any of the fields "Intro image" or "Full article image"
  4. Go to the frontend, and check depending on the option that you put in the module, it shows or not, the image correctly

Expected result

The module shows or not, the fields "Intro image" or "Full article image" of the article correctly

Actual result

The current option only display images in the article context.

Documentation Changes Required

New module option added.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar carlitorweb carlitorweb - open - 14 Apr 2018
avatar carlitorweb carlitorweb - change - 14 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2018
Category Language & Strings Modules Front End
avatar carlitorweb carlitorweb - change - 14 Apr 2018
The description was changed
avatar carlitorweb carlitorweb - edited - 14 Apr 2018
avatar carlitorweb carlitorweb - change - 14 Apr 2018
Labels Added: ? ?
avatar carlitorweb
carlitorweb - comment - 14 Apr 2018

Is done, thank you @Quy

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Apr 2018

I have tested this item successfully on a3b2f08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Apr 2018 - Tested successfully
avatar bubi-luka
bubi-luka - comment - 15 Apr 2018

I have tested this item successfully on a3b2f08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar bubi-luka bubi-luka - test_item - 15 Apr 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Apr 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Apr 2018

Ready to Commit after two successful tests.

avatar carlitorweb carlitorweb - change - 15 Apr 2018
Labels Added: ?
avatar carlitorweb
carlitorweb - comment - 15 Apr 2018

Thank you again @Quy . I need have more careful with this small things.

avatar Quy
Quy - comment - 15 Apr 2018

You're very welcome. For reference, read Coding Standards Manual.

avatar carlitorweb
carlitorweb - comment - 16 Apr 2018

Done again @Quy . I revert also the "default" value to 0

avatar brianteeman
brianteeman - comment - 17 Apr 2018

please remove the RTC status as this PR is not backwards compatible and it also changes the way that the module works

Issue 1
Create an article with an image INSIDE the article
create a newsflash module and set the show images to NO
Test and you will see that there are no images displayed
Apply this PR and do NOT change anything in the module
Check the module on the front end and you will see that images ARE displayed

Issue 2
There is no longer a way to not display images that are INSIDE the article
The no image option only stops the display of intro and full images
the intro image option will display the images INSIDE the article and the intro image
The full image option will display the images INSIDE the article and the full image

avatar brianteeman
brianteeman - comment - 17 Apr 2018

I have tested this item 🔴 unsuccessfully on 9d9e606


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar brianteeman brianteeman - test_item - 17 Apr 2018 - Tested unsuccessfully
avatar Quy Quy - change - 17 Apr 2018
Status Ready to Commit Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2018

@brianteeman Status is back on Pending by @Quy at Issue Tracker but Label "RTC" on Github is shown, can't remove it here.

avatar brianteeman
brianteeman - comment - 17 Apr 2018

@franz-wohlkoenig if a status is changed on the issue tracker it will be updated on github but only when a comment is made. Your comment triggered the change. So in future if a change is made on the issue tracker you should always make a comment explaining that yu made the change and then it will work here on github too

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Apr 2018

thanks Brian, so its vica versa working to set RTC and wrote here > haven't thought about it :-

avatar carlitorweb
carlitorweb - comment - 17 Apr 2018

@brianteeman the issue you talk about is more related to the user context than the module. Why need the module remove any image you put INSIDE the article? If I want my article to have or not an image in the introtext, then I just put it or not, INSIDE the introtext.
Anyway, can be another param asking for this, in case the user wants also, show or not, the image INSIDE the article

avatar carlitorweb
carlitorweb - comment - 17 Apr 2018

Also, in my opinion, I think the option to put an image that belongs to the text of the article, is an option only a few users use it.

avatar brianteeman
brianteeman - comment - 17 Apr 2018
  1. Unless you have a magic ball you can not know how many people use the current options
  2. You have to consider backwards compatibility. You can not make a change that will effect the display of millions of web sites
avatar carlitorweb
carlitorweb - comment - 17 Apr 2018

No, I do not have a magic ball, that is why I wrote "in my opinion", just counting with my small knowledge about this option.
Ok, what I will do is, revert the change, and make a new param leaving the old intact. In this way, we are only adding a new option to the module, without modifying it

avatar carlitorweb carlitorweb - change - 17 Apr 2018
Labels Removed: ?
avatar carlitorweb
carlitorweb - comment - 17 Apr 2018

I revert the change. Now, this option is with a new param. Also, I modify the description for the old one, trying to avoid confusion, if is possible change this description.

avatar brianteeman
brianteeman - comment - 17 Apr 2018

Thank you

avatar carlitorweb
carlitorweb - comment - 17 Apr 2018

You welcome @brianteeman

avatar brianteeman
brianteeman - comment - 17 Apr 2018

B/C images all fixed now.

I think it would be best if you updated the old string "Show Images" to "Show article images" or something like that - just so that people dont think it is related to the other options below

avatar carlitorweb
carlitorweb - comment - 17 Apr 2018

Is true. Done. Thank you again.

avatar ReLater
ReLater - comment - 19 Apr 2018

I have tested this item successfully on 68e2e54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar ReLater ReLater - test_item - 19 Apr 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 24 Apr 2018

Ok done. Hope is better now.

avatar ReLater
ReLater - comment - 24 Apr 2018

I have tested this item successfully on 5efd862


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar ReLater ReLater - test_item - 24 Apr 2018 - Tested successfully
avatar Quy
Quy - comment - 24 Apr 2018

I have tested this item successfully on 5efd862


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar Quy Quy - test_item - 24 Apr 2018 - Tested successfully
avatar Quy Quy - change - 24 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20169.

avatar carlitorweb carlitorweb - change - 4 May 2018
The description was changed
avatar carlitorweb carlitorweb - edited - 4 May 2018
avatar mbabker mbabker - change - 28 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-28 14:59:22
Closed_By mbabker
Labels Added: ? ?
Removed: ?
avatar mbabker mbabker - close - 28 May 2018
avatar mbabker mbabker - merge - 28 May 2018
avatar ute-sch
ute-sch - comment - 13 May 2019

Please help (my Joomla's up to date):
The Article-Newsflash Module doesn't show the Intro or Full image, as offered in the field.

What I found out - sorry, I'm not a programmer:

In the options field there's an english-german language mixup - see the screenshot:
http://www.schultz-hamburg.de/joomla-newsflash.png
Doesn't the module find the appropriate value?
I couldn't find the file where the values are translated and assigned to the corresponding keys.

I only found the german translation file de-DE_mod_articles-news_ini where the following lines are missing:
MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_DESC="... german translation ..." MOD_ARTICLES_NEWS_FIELD_IMAGES_ARTICLE_LABEL="... german translation ..."
This is not a big issue, it's only the translation of the label and the description - so I tried and added it on my site. Of course, it didn't help with the bug.

Thanks for your patience!

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 May 2019

@ute-sch please ask on Forum

Add a Comment

Login with GitHub to post a comment