[#20152] - [4.0] Event - onUserBeforeDataValidation
- Closed
- 14 May 2019
- Medium
- Build: 4.0-dev
- # 20152
- Diff
- BrainforgeUK:4.0-dev
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Failure continuous-integration/drone/pr the build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19584 .
Summary of Changes
Added event onContentValidateData
Testing Instructions
Create a field plugin which implements onContentValidateData function like this...
public function onContentValidateData($form, &$data) {
// Change the data in some way
}
Expected result
The data get's changed.
Actual result
The data get's changed.
Documentation Changes Required
Add documentation for onContentValidateData event.
Add documentation for the existing, but undocumented and now deprecated, onUserBeforeDataValidation event.
This event will only get triggered when validate() overridden by a user component model.
brainforgeUK
- | Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Now got a Javascript conflict - any suggestions?
Not sure what you mean
I think he is referring to the false error with drone.
See lines 556 to 561 of
http://ci.joomla.org/joomla/joomla-cms/7735/5
Also mentioned here, but how can I resolved?
jasmine/jasmine#1486
| Category | Libraries | ⇒ | Modules Administration Libraries |
| Category | Libraries Modules Administration | ⇒ | Modules Administration SQL Installation Libraries |
You have added completely unrelated code3 to this issue
You must use a different branch and create a different pull request for each issue you are trying to resolve
In your git client revert this latest change, commit and push
Then create a NEW branch and pull from staging
Make your new changes, commit and push
go to https://github.com/joomla/joomla-cms and you will see info that you can create a new pull request from your new branch
franz-wohlkoenig
- | Title |
|
||||||
@BrainforgeUK can you update your PR to solve the conflicts and remove the changes visible on https://github.com/joomla/joomla-cms/pull/20152/files that are not related to the PR? Thanks in advance!
The Delete option is disabled for me in the ... menu for each of those not required.
The only change required for this issue is the last one listed in form.php
Cannot see how to get round this if the delete menu item is disabled.
Could it be that the repo is no longer available?
@Quy Indeed, a new PR should be made as the old branch has been deleted. I am not sure if @BrainforgeUK can restore the original branch. Otherwise it is easier to make a new PR.
Created new pull request.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-14 19:45:25 |
| Closed_By | ⇒ | BrainforgeUK | |
| Labels |
Removed:
J4 Issue
|
||
Please can you look at resolving the conflicts