? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
9 Apr 2018

Pull Request for Issue # .

Summary of Changes

Fixes the debug display backend/frontend

Testing Instructions

Apply PR and check the bedug output

Expected result

screen shot 2018-04-09 at 16 13 04
screen shot 2018-04-09 at 16 13 22

Actual result

broken

Documentation Changes Required

There is a mild B/C break here: the old code in the debug plugin is based on the </body> tag but the new expects <joomla-debug></joomla-debug>. If we go ahead with @mbabker 's proposal to drop the debug from the plugin then I would suggest to also have a <jdoc:include type="debug"/> with the appropriate renderer as that will render the extra custom tag useless...

avatar dgrammatiko dgrammatiko - open - 9 Apr 2018
avatar dgrammatiko dgrammatiko - change - 9 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2018
Category Administration Templates (admin) Front End Plugins Templates (site)
avatar laoneo
laoneo - comment - 9 Apr 2018

As I reverted the commit from pr #20061, you need to solve the conflict first.

avatar dgrammatiko dgrammatiko - change - 9 Apr 2018
Labels Added: ?
a06cf14 9 Apr 2018 avatar dgrammatiko more
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2018
Category Administration Templates (admin) Front End Plugins Templates (site) Administration Templates (admin) JavaScript Front End Plugins Templates (site)
avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

@laoneo don't merge this yet!

avatar laoneo
laoneo - comment - 11 Apr 2018

Let us know when ready for another test round.

avatar wilsonge wilsonge - change - 13 Apr 2018
Title
[4.0] Fix debug
[4.0] [WIP] Fix debug
avatar wilsonge wilsonge - edited - 13 Apr 2018
avatar dgrammatiko
dgrammatiko - comment - 21 May 2018

This needs another solution as my proposal is not B/C at all

avatar dgrammatiko dgrammatiko - change - 21 May 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-05-21 20:51:41
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 21 May 2018

Add a Comment

Login with GitHub to post a comment