? Pending

User tests: Successful: Unsuccessful:

avatar amone4
amone4
2 Apr 2018

Pull Request for Issue #19471 .

Summary of Changes

Changed the markup to include the debug panel in the same wrapper as the normal content

Testing Instructions

Activate the debug panel by going into Global Configuration > System tab

Expected result

See the complete debug panel at the end of each page

Actual result

Part of the debug panel is hidden by Joomla's lateral menu administrative pages

Documentation Changes Required

None, I guess

avatar amone4 amone4 - open - 2 Apr 2018
avatar amone4 amone4 - change - 2 Apr 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2018
Category JavaScript Front End Plugins
avatar rdeutz rdeutz - change - 2 Apr 2018
Labels Added: ?
avatar laoneo laoneo - close - 9 Apr 2018
avatar laoneo laoneo - merge - 9 Apr 2018
avatar laoneo laoneo - change - 9 Apr 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-09 12:38:47
Closed_By laoneo
avatar Anu1601CS
Anu1601CS - comment - 9 Apr 2018

@laoneo we have some problem with this PR
Debug panel works fine in back-end but in front end it seems like this

screenshot from 2018-04-09 18-16-59

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

@ciar4n can you take a look at the debug console in the front end?

avatar Anu1601CS
Anu1601CS - comment - 9 Apr 2018

And one more thing debug console in admin login is not showing.

avatar Anu1601CS
Anu1601CS - comment - 9 Apr 2018

@laoneo

Does reverting this line help https://github.com/joomla/joomla-cms/pull/20061/files#diff-78d82eb8bd4c1f14a8e99e82ada1daf9R355 ?

No, this make debug console more messy then before this PR.
screenshot from 2018-04-09 18-44-42

I think this is not a proper fix for this.

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

@amone4 @laoneo this PR was wrong. What we need actually is to move the debug module inside the wrapper:
screen shot 2018-04-09 at 15 27 45

avatar laoneo
laoneo - comment - 9 Apr 2018

Can you make a new pr for it?

avatar Anu1601CS
Anu1601CS - comment - 9 Apr 2018

Can you make a new pr for it?

Me ?

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

Here is what I'm thinking:
in the template:

<joomla-debug><jdoc:include type="modules" name="debug" style="none" /></joomla-debug>

in the plugin:

		echo str_replace('<joomla-debug></joomla-debug>', '<joomla-debug>' . implode('', $html) . '</joomla-debug>', $contents);

That will decouple the markup form the body tag, but it's also a minor B/C break (?)

Let me know if it's ok and then will push the changes in a PR

avatar laoneo
laoneo - comment - 9 Apr 2018

If you can, would be great. Guess you need to revert this one as well then.

avatar laoneo
laoneo - comment - 9 Apr 2018

You want to make a CE out of it?

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

nah, I just wanted to increase specificity without adding id or some weird class...

avatar Anu1601CS
Anu1601CS - comment - 9 Apr 2018

@laoneo I can but tomorrow and day after tomorrow is my university exam.
After the exam, I take a look on it. :)

avatar laoneo
laoneo - comment - 9 Apr 2018

@dgrammatiko yes, please make a new pr if you have time. I'm going to revert this one anyway.

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

Ok will do. By the way I just saw #11840 due to comment in another issue, so maybe will be a good idea to introduce <jdoc:include type="debug" /> and totally decouple the debug from the modules? (not to be done in the comming PR though.. ?)

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2018

@laoneo there you go: #20120

Add a Comment

Login with GitHub to post a comment