[#20055] - [4.0] Database Driver Fixes
- Fixed in Code Base
- 14 Apr 2018
- Medium
- Build: 4.0-dev
- # 20055
- Diff
- mbabker:db-statements
User tests: Successful: Unsuccessful:
Pull Request for Issue #18660
Summary of Changes
Because I seriously doubt the Framework pull request is going to get the attention it needs, I'm bringing the development branch the pull request is based on into the CMS as a PR in hopes that one or two people might actually test it instead of us having to resort to a blind merge and hope for the best scenario.
See the linked pull request for details about the actual code changes involved in this pull request, and the linked issue for the various issues exposed in the CMS environment that should be fixed with this pull request.
Testing Instructions
When installing Joomla, depending on which PHP extensions are installed and enabled in your environment, you should be able to install Joomla on:
- MySQLi (requires PHP's
ext/mysqlito be enabled, prior to this PR it required that the MySQL support be compiled withmysqlndbut now environments where the MySQL support is compiled withlibmysqlshould be supported) - PDO MySQL (requires PHP's
ext/pdowith MySQL support to be enabled) - PostgreSQL (requires PHP's
ext/pgsqlto be enabled) - PDO PostgreSQL (requires PHP's
ext/pdowith PostgreSQL support to be enabled)
If using either of the PDO drivers, you will most likely need #19989 to be applied in your environment (if/when that PR is merged this PR will be rebased so the branch includes those changes).
Once installed, Joomla should be able to be used as normal (well, as normal as one can against the current 4.0 development state).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change Libraries |
quick test. installer showed all 4 options
install successfully with mysql and mysqlpdo
rdeutz
- | Labels |
Added:
?
?
?
|
||
I can confirm the mysql pdo install works. But I don't know if it is expected that the database is not created during the install.
Creating the database for PDO MySQL is covered by #19989 and is honestly a best effort thing in general (it requires us to parse the exception messages and try to determine if we can create it, IIRC neither PostgreSQL driver actually supports the create database operation in our installer).
I have tested this item
looks good than. I'm going to check the other PR too. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20055.
Just so it's clear here, while testing of normal use of the application is going to help validate these changes, I really do need people to do a real code review here because I am making quite a few underlying API changes in the database API, some of which have B/C implications.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-12 13:22:37 |
| Closed_By | ⇒ | mbabker |
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-04-12 13:22:37 | ⇒ | |
| Closed_By | mbabker | ⇒ |
| Status | New | ⇒ | Pending |
| Category | External Library Composer Change Libraries | ⇒ | Repository External Library Composer Change Libraries |
Work is complete from the FW repository to get this effort stable.
When running composer update to pull in the changes, I ended up getting several other package updates. I have found that our composer.lock file has been changed to have updated dependencies without the respective changes in the libraries/vendor directory committed. Therefore those changes are now included in this pull request because I can't do anything to fix that without further corrupting things.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-14 09:03:15 |
| Closed_By | ⇒ | wilsonge |
Too late for me tonight but I will test installation etc tomorrow morning
THANKS