[#20054] - [4.0] Email cloak unittests are failing on 4.0
- Closed
- 2 Apr 2018
- Medium
- Build: staging
- # 20054
Steps to reproduce the issue
http://ci.joomla.org/joomla/joomla-cms/4269/12
Expected result
Drone works
Actual result
Drone fails on 4.0-dev unittests
System information (as much as possible)
After the merge of:
#19089 ([4.0] email cloaking without inline script)
#20053 (correction to the webcomponent call)
Additional comments
I have no quick idea what is wrong here :(
joomla-cms-bot
- | Labels |
Added:
?
|
||
Here is a PR: joomla/test-unit#1
But to me that should not produce a Exception: Failed to start application error i would just expect a failed test.
Just done http://ci.joomla.org/joomla/joomla-cms/4273/10 lets see what happens.
@zero-24 it needs a bit more I think: joomla/test-unit#2
BTW: cannot marge my own PR, so @wilsonge
I have no access to that repo to merge too :(
give me 5 secs the PR is not correct
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | com_mailto |
it is merged and I tagged the repo so that it will be used
brianteeman
- | Labels |
Added:
J4 Issue
|
||
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-02 17:44:46 |
| Closed_By | ⇒ | rdeutz |
I will close it because I fixed it, with a couple of commits. For the record:
JHtmlEmail has now a dependency to HTMLHelper::webcomponet and this has a hardcoded dependency to Factory. So the falling test is no longer a Unit test and I removed the test.
The test file should be updated here: https://github.com/joomla/test-unit/blob/master/suites/libraries/cms/html/JHtmlEmailTest.php