[#2003] - [#32036] Removing MooTools dependencies form administrator/templates folder
- Closed
- 6 Feb 2015
- Medium
- Build: master
- # 2003
- Diff
- AshanFernando:gsoc-mootools-jquery-administratortemplates
- Foreign ID 32036
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in administrator/templates folder.
Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32036&start=575
| Status | New | ⇒ | Pending |
| Build | ⇒ | . |
| Category | ⇒ | JavaScript |
as is this issue still valid. but pull requests to the master branch of this repo are not longer accepted. Can you close this pull request and submit a new one against the staging branch with the fixes that @dgt41 noted?
If there is no response in a month we will close the PR here.
Thanks for understanding!
@zero-24 as there was no response I went ahead and changed #5245 to incorporate the changes proposed here, and the one I propose in the comment above. I hope @AshanFernando is ok with this
@AshanFernando All kudos to you!!! You’ve done an exceptional job here.
So we can close here @AshanFernando @dgt41 ?
Based on @AshanFernando and @dgt41 comments I am closing this See #5245
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-06 23:10:48 |
| Title |
|
||||||
@AshanFernando Can you update this PR?
Also can you:
rename
JHtml('behavior.formvalidation');toJHtml('behavior.formvalidator');replace the inline scripts with `JFactory::getDocument()->addScriptDeclaration("code");
It would be easier if you break it to smaller parts, e.g. per component: com_content, com_admin etc