? ? Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
30 Mar 2018

Summary of Changes

The nested table class has a debug mode which can be enabled by developers to get additional output of the inner workings of that class. Without this PR, a full DB query (that i.e. might include HTML markup) would be outputted without any escaping, breaking the debug output with the then parsed HTML.

Testing Instructions

  1. Login to the administrator area, navigate to the screen where you can create a new com_content category and fill that form - do not submit it yet!

Open administrator/components/com_categories/tables/category.php, enable debugging by adding the following property:

protected $_debug = 1;

Open libraries/src/Application/WebApplication and empty the redirect() method to suppress the redirect after save.

Hit save, see a debug output comparable to this screenshot.
voila_capture 2018-03-30_11-40-36_am

Apply patch, restore redirect method, navigate to form again, empty the redirect method and save again. Check that the debug output still works.

Expected result

Debug output is escaped

Actual result

Debug output is unescaped

Documentation Changes Required

None

avatar SniperSister SniperSister - open - 30 Mar 2018
avatar SniperSister SniperSister - change - 30 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2018
Category Libraries
avatar zero-24
zero-24 - comment - 30 Mar 2018

I have tested this item successfully on e55ddc1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20024.

avatar zero-24 zero-24 - test_item - 30 Mar 2018 - Tested successfully
avatar Quy
Quy - comment - 30 Mar 2018

I have tested this item successfully on e55ddc1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20024.

avatar Quy Quy - test_item - 30 Mar 2018 - Tested successfully
avatar Quy Quy - change - 30 Mar 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Mar 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20024.

avatar mbabker mbabker - close - 1 Apr 2018
avatar mbabker mbabker - merge - 1 Apr 2018
avatar mbabker mbabker - change - 1 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-01 15:33:00
Closed_By mbabker
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment