? ? Pending

User tests: Successful: Unsuccessful:

avatar eshiol
eshiol
29 Mar 2018

Summary of Changes

Fixed User Custom Field Tab in Single Contact view with Tab format

Testing Instructions

From the backend
Open the menu item About Joomla > Using Joomla! > Using Extensions > Components > Contact Component > Single Contact
Set the option "Display format" to "Tabs"
Set the option "Show User Custom Fields" to "All"

Link the contact "Contact Name Here" to the user "Super User"
Set the option "User Profile" to "Show" in the Contact options

Enable the plugin User - profile

Create a custom Field for Users

Compile the custom field of the user "Super User"
Compile a field in the profile of the user "Super User"

From the frontend
Click on the menu item About Joomla > Using Joomla! > Using Extensions > Components > Contact Component > Single Contact

Expected result

If you click on the Profile tab you show the user profile fields
If you click on the Fields tab you show the user custom fields

Actual result

Both Profile and Fields tabs show you the user profile fields

System information (as much as possible)

Joomla! 3.8.6
Learn Joomla English (GB) Sample Data

avatar eshiol eshiol - open - 29 Mar 2018
avatar eshiol eshiol - change - 29 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2018
Category Front End com_contact
avatar brianteeman
brianteeman - comment - 29 Mar 2018

I cannot replicate exactly your issue although I can confirm its a bug. See screenshots.
Your code however doesnt change anything visibly

chrome_2018-03-29_22-17-06

avatar Quy
Quy - comment - 29 Mar 2018

I have tested this item successfully on 37f4eb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20023.

avatar Quy Quy - test_item - 29 Mar 2018 - Tested successfully
avatar Quy
Quy - comment - 29 Mar 2018

@brianteeman I cannot reproduce your screenshot. This PR addresses the issue where the Profile tab and Fields tab point to the same link.

jQuery(function($){ $("#myTabTabs").append($("<li class=\"\"><a href=\"#display-profile\" data-toggle=\"tab\">Profile<\/a><\/li>")); });
jQuery(function($){ $("#myTabTabs").append($("<li class=\"\"><a href=\"#display-profile\" data-toggle=\"tab\">Group 1<\/a><\/li>")); });
avatar brianteeman
brianteeman - comment - 29 Mar 2018

contact

avatar brianteeman brianteeman - change - 29 Mar 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-03-29 23:03:55
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 29 Mar 2018
avatar brianteeman brianteeman - change - 29 Mar 2018
Status Closed New
Closed_Date 2018-03-29 23:03:55
Closed_By brianteeman
avatar brianteeman brianteeman - change - 29 Mar 2018
Status New Pending
avatar brianteeman brianteeman - reopen - 29 Mar 2018
avatar Quy
Quy - comment - 29 Mar 2018

Please create the custom fields under Users per the Testing Instructions.

avatar faustonenci
faustonenci - comment - 5 Apr 2018

Hi, we have an issue here : we see correctly tab FIELDS ( we can see the custom field we created), but there is no PROFILE Tab. We have CONTACT Tab: in this tab, we can see the label of some profile fields (Street Address,Suburb,State,Zip Code,Country,Phone,Telephone,Fax) but NO VALUE.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20023.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Apr 2018

@ Please ask help on the forums. This repository concerns in first Place Joomla-Core coding, thanks.

avatar brianteeman
brianteeman - comment - 8 May 2018

I have tested this item successfully on 37f4eb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20023.

avatar brianteeman brianteeman - test_item - 8 May 2018 - Tested successfully
avatar Quy Quy - change - 8 May 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 8 May 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20023.

avatar mbabker mbabker - change - 10 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-10 00:56:09
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 10 May 2018
avatar mbabker mbabker - merge - 10 May 2018

Add a Comment

Login with GitHub to post a comment